peterhcharlton/info

Tools for research

info's Issues

Question about "info/collating_datasets/download_and_collate_mimiciii_ppg_af_dataset.m"

Hi, Dr.Charlton.

Thanks a lot for sharing your code, its really helps my study.
Somehow, I found some problem in the matlab scripts mentioned in the title.
Between the lines 454-463:
_

period_deb = rec_file_info.deb;
if ~isempty(onset_time)
period_deb = period_deb + datenum(onset_time, 'HH:MM:SS');
end
% - start time of relevant period for this subject
if ~isempty(offset_time)
period_fin = period_deb + datenum(offset_time, 'HH:MM:SS');
else
period_fin = inf;
end

_

" datenum(onset_time, 'HH:MM:SS')" may doesn't work well. Because its equals to ' 738157' in my case, so the recordings period always out of the range of the start and end time of annotation period.
And in the following codes, only the record-level AF annotation (af_status, lines 321) are used, the "in_period"(lines 470) may not be used.
Could " datenum(onset_time, 'HH:MM:SS')" be replaced with " period_deb =period_deb+datenum(onset_time, 'HH:MM:SS') - datenum('00:00:00', 'HH:MM:SS') ", and then replace "af_status" with "in_period"?

Thanks,
Luo