phanx-wow/anyfavoritemount

WoW AddOn — (DEPRECATED) Set any mount as a favorite, even if the default UI doesn't approve.

anyfavoritemount's Issues

[bug] Issue with player targeting and mouseover

Hello,

This addon is great, however it randomly prevents me from doing a combat rez, as weird as it sounds. I've got a mouseover macro that I use on the player's name in the group/raid players list on the left.

From times to times, I can't use the macro, saying that "i have no target". When I try to click on the player to actually target him, it says that "the addon has attempted to use a forbidden function" (rough translation as my game is in french).

If you want some more detailled logs (like what is the conflicting function), tell me how to get them and I'll grab them as soon as the bug comes again.

Thanks !

Error

Seeing this error the past couple of nights, not sure if it just happens when joining a raid or not. I'm also using MountMe along with this addon...

[ADDON_ACTION_BLOCKED] AddOn 'AnyFavoriteMount' tried to call the protected function 'CompactRaidFrame1:Show()'.
!BugGrabber\BugGrabber.lua:573: in function <!BugGrabber\BugGrabber.lua:573>
[C]: in function Show' FrameXML\CompactUnitFrame.lua:330: in functionCompactUnitFrame_UpdateVisible'
FrameXML\CompactUnitFrame.lua:280: in function `CompactUnitFrame_UpdateAll'
FrameXML\CompactUnitFrame.lua:115: in function <FrameXML\CompactUnitFrame.lua:51>

Chauffeured Mekgineer's Chopper in favorites causes breakage

Bugger report:

24x AnyFavoriteMount\Addon.lua:106: attempt to index field '?' (a nil value)
AnyFavoriteMount\Addon.lua:106: in function <AnyFavoriteMount\Addon.lua:98>
AnyFavoriteMount\Addon.lua:126: in function 'Summon'
[string "C_MountJournal.Summon(0)"]:1: in main chunk
[C]:: in function 'RunScript'
FrameXML\ChatFrame.lua:2091: in function '?'
FrameXML\ChatFrame.lua:4454: in function 'ChatEdit_ParseText'
FrameXML\ChatFrame.lua:4108: in function 'ChatEdit_SendText'
FrameXML\ChatFrame.lua:2707: in function <FrameXML\ChatFrame.lua:2700>
[C]:: in function 'RunMacroText'
FrameXML\SecureTemplates.lua:463: in function 'handler'
FrameXML\SecureTemplates.lua:649: in function <FrameXML\SecureTemplates.lua:597>

Locals:

Locals:
index = 0
targetType = 2
SWIMMING = 3
ns = <table> {
 CanFly = <function> defined @AnyFavoriteMount\API_CanFly.lua:33
}
FLYING = 2
GROUND = 1
FillMountList = <function> defined @AnyFavoriteMount\Addon.lua:98
randoms = <table> {
 1 = 2
 2 = 13
 3 = 94
 4 = 107
}
Summon = <function> defined =[C]:-1

Save favorites per character

Maybe.

(from #1)

Doesn't work directly from action buttons

Need to investigate exactly what happens when the user drags the "Summon Random Mount" button from the mount journal to an action button and feed that into the custom logic if possible, or overwrite the button's drag script to create/pickup a macro instead if not.

(from #1)

Both features did not work?

I happened to know this addon has implemented all the 3 features I was looking for, so tried it out immediately (with the latest 6.0.3.10 version from curse). The results did not look good, unfortunately:

1. Character-specific mount options: while your addon may have supported it, another addon I was using works nicely anyway.

2. Class-specific mount being able to set as favorite: your addon did turn on the option, but for reasons I don't know, such mount (e.g. Paladin's Charger) was still not able to summon up with the button -- the button turned grey too.

3. Those apparently flying mounts (e.g. carpets, cloud, etc.) are not allowed to summon as ground mounts: it is the additional feature your addon claimed to support too, but those clumsy flying mounts are still summoned as ground mounts, and the weird thing was, even the flying mounts that were not previously summoned as ground mounts with the built-in mechanism (e.g. Blue Drake) were also summoned as ground mounts now, with your addon.

Could you please help to take a look at the issues? I really hope that one single addon could provide all I (and I believe many other people) needed with the built-in mount mechanism.

Thanks!

JoinBattlefield blocked by taint

Hi Phanx- love the addon, and thanks for dealing with something that really should be default behavior in WoW. :)

I keep running into this error however...

Date: 2016-09-25 10:07:17
ID: 1
Error occured in: AddOn: AnyFavoriteMount
Count: 1
Message: Error: AddOn AnyFavoriteMount attempted to call a forbidden function (JoinBattlefield()) from a tainted execution path.
Debug:

Blizzard_PVPUI\Blizzard_PVPUI.lua:551: HonorFrame_Queue()

  [string "*:OnClick"]:1

Locals:
None