phanx-wow/betterarchaeologyui

WoW AddOn — Improves the Blizzard archaeology UI.

betterarchaeologyui's Issues

Missing Future Artifacts

Hi, really like your addon.
I found out that atleast 1 Item is missing in the Future Artifacts page namely.
http://www.wowhead.com/item=64377/zinrokh-destroyer-of-worlds

I do not know if more are missing, right now i only see 2 missing Artifacts.
Edit: Found the bug, another Addon caused some problems.

Error with addon

When i open the addon it gives me this error:

Message: ...face\AddOns\BetterArchaeologyUI\CurrentArtifacts.lua:300: attempt to compare nil with number
Time: 12/26/15 18:54:53
Count: 1
Stack: ...face\AddOns\BetterArchaeologyUI\CurrentArtifacts.lua:300: in function <...face\AddOns\BetterArchaeologyUI\CurrentArtifacts.lua:275>
[C]: in function `UpdateFrame'
...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:615: in function <...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:554>
[C]: in function `ArchaeologyFrame_OnTabClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>
[C]: in function `Click'
...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:121: in function <...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:111>
[C]: in function `Show'
Interface\FrameXML\UIParent.lua:2165: in function `SetUIPanel'
Interface\FrameXML\UIParent.lua:2009: in function `ShowUIPanel'
Interface\FrameXML\UIParent.lua:1880: in function <Interface\FrameXML\UIParent.lua:1876>
[C]: in function `SetAttribute'
Interface\FrameXML\UIParent.lua:2630: in function `ShowUIPanel'
...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:49: in function `ArchaeologyFrame_Show'
Interface\FrameXML\UIParent.lua:1495: in function <Interface\FrameXML\UIParent.lua:825>
[C]: in function `UseAction'
Interface\FrameXML\SecureTemplates.lua:348: in function `handler'
Interface\FrameXML\SecureTemplates.lua:649: in function `SecureActionButton_OnClick'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>

Locals: self = ArchaeologyFrameSummaryPage
raceName = "Ogre"
raceIcon = "Interface\ARCHEOLOGY\Arch-Race-Ogre"
keystoneItemID = 109584
haveFragments = 242
needFragments = 45
maxFragments = 250
numKeystones = 1
data = <table> {
 artifactRarity = 0
 numSocketsFilled = 0
 numSockets = 0
 bonusFragments = 0
 artifactName = "Unknown"
 raceIndex = 15
 new = true
}

This error appears with all my other addons disabled, i play on EU with English language. Let me know if you need more info to hunt down this bug.
Thanks for the addon.

Error collection

Error identifying race by keystone: 109585 Arakkoa Cipher
Error identifying race by keystone: 108439 Draenor Clan Orator Cane
Error identifying race by keystone: 52843 Dwarf Rune Stone
Error identifying race by keystone: 0 nil
Error identifying race by keystone: 95373 Mantid Amber Sliver
Error identifying race by keystone: 79869 Mogu Statue Piece
Error identifying race by keystone: 64396 Nerubian Obelisk
Error identifying race by keystone: 63127 Highborne Scroll
Error identifying race by keystone: 109584 Ogre Missive
Error identifying race by keystone: 64392 Orc Blood Text
Error identifying race by keystone: 79868 Pandaren Pottery Shard
Error identifying race by keystone: 64397 Tol'vir Hieroglyphic
Error identifying race by keystone: 63128 Troll Tablet
Error identifying race by keystone: 64395 Vrykul Rune Stick

1x ...faceBetterArchaeologyUI\MissingArtifacts.lua:149: attempt to index field 'artifact' (a nil value)
...faceBetterArchaeologyUI\MissingArtifacts.lua:149: in main chunk
[C]: in function `LoadAddOn'
Archy\Archy-6.2.2.2.lua:1687: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:145: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:145>
[string "safecall Dispatcher[1]"]:4: in function <[string "safecall Dispatcher[1]"]:4>
[C]: ?
[string "safecall Dispatcher[1]"]:13: in function `?'
...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0-6.lua:90: in function `Fire'
Ace3\AceEvent-3.0\AceEvent-3.0-3.lua:120: in function <Ace3\AceEvent-3.0\AceEvent-3.0.lua:119>

Locals:
(*temporary) = "Blizzard_ArchaeologyUI"
(*temporary) = <function> defined =[C]:-1

2 Errors 1 Question

When running adcc590 I get

Error getting bonus fragments for Draenor Clans
Error getting bonus fragments for Arakkoa

on login. Also is the Future Artifacts panel just a placeholder for now or is it supposed to show all unfinished projects in this version? Only shows two for me.

when picking up item this comes up.

Im suspecting this is from your addon.

Message: ...ns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:190: attempt to call method 'UpdateFrame' (a nil value)
Time: Fri Nov 24 11:50:37 2023
Count: 3
Stack: ...ns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:190: attempt to call method 'UpdateFrame' (a nil value)
[string "@Interface/AddOns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua"]:190: in function <...ns/Blizzard_ArchaeologyUI/Blizzard_ArchaeologyUI.lua:156>

Locals: self = ArchaeologyFrame {
0 =
summaryPage = ArchaeologyFrameSummaryPage {
}
raceFilterDropDown = ArchaeologyFrameRaceFilter {
}
SetPortraitShown = defined @Interface/SharedXML/PortraitFrame.lua:102
GetTitleText = defined @Interface/SharedXML/PortraitFrame.lua:28
SetPortraitTexCoord = defined @Interface/SharedXML/PortraitFrame.lua:98
bgLeft = ArchaeologyFrameBgLeft {
}
SetPortraitTextureRaw = defined @Interface/SharedXML/PortraitFrame.lua:84
SetPortraitToClassIcon = defined @Interface/SharedXML/PortraitFrame.lua:92
tab1 = ArchaeologyFrameSummarytButton {
}
TitleContainer = Frame {
}
SetTitleMaxLinesAndHeight = defined @Interface/SharedXML/PortraitFrame.lua:49
SetTitleColor = defined @Interface/SharedXML/PortraitFrame.lua:32
tab3 = ArchaeologyFrameFutureButton {
}
SetTitle = defined @Interface/SharedXML/PortraitFrame.lua:36
SetTitleOffsets = defined @Interface/SharedXML/PortraitFrame.lua:54
completedPage = ArchaeologyFrameCompletedPage {
}
futurePage = ArchaeologyFrameFuturePage {
}
SetBorder = defined @Interface/SharedXML/PortraitFrame.lua:67
layoutType = "PortraitFrameTemplate"
SetFrameLevelsFromBaseLevel = defined @Interface/SharedXML/PortraitFrame.lua:120
SetPortraitToBag = defined @Interface/SharedXML/PortraitFrame.lua:80
SetPortraitAtlasRaw = defined @Interface/SharedXML/PortraitFrame.lua:88
SetPortraitToUnit = defined @Interface/SharedXML/PortraitFrame.lua:76
PortraitContainer = Frame {
}
Bg = ArchaeologyFrameBg {
}
currentFrame = ArchaeologyFrameFuturePage {
}
GetPortrait = defined @Interface/SharedXML/PortraitFrame.lua:63
SetTitleFormatted = defined @Interface/SharedXML/PortraitFrame.lua:40
NineSlice = Frame {
}
TopTileStreaks = Texture {
}
Inset = ArchaeologyFrameInset {
}
infoButton = ArchaeologyFrameInfoButton {
}
SetPortraitToAsset = defined @Interface/SharedXML/PortraitFrame.lua:72
SetPortraitTextureSizeAndOffset = defined @Interface/SharedXML/PortraitFrame.lua:106
rankBar = ArchaeologyFrameRankBar {
}
CloseButton = ArchaeologyFrameCloseButton {
}
artifactPage = ArchaeologyFrameArtifactPage {
}
tab2 = ArchaeologyFrameCompletedButton {
}
factionIcon = ArchaeologyFrameFactionIcon {
}
bgRight = ArchaeologyFrameBgRight {
}
selectedTab = 3
helpPage = ArchaeologyFrameHelpPage {
}
}
event = "CURRENCY_DISPLAY_UPDATE"
(*temporary) = nil
(*temporary) = ArchaeologyFrameFuturePage {
0 =
currentPage = 1
raceFilter = 0
pageText = FontString {
}
nextPageButton = ArchaeologyFrameFuturePageNextPageButton {
}
infoText = FontString {
}
prevPageButton = ArchaeologyFrameFuturePagePrevPageButton {
}
artifacts =

{
}
}
(*temporary) = "attempt to call method 'UpdateFrame' (a nil value)"

getting a error

2x ...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:186: attempt to call method 'UpdateFrame' (a nil value)
...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:186: in function <...ns\Blizzard_ArchaeologyUI\Blizzard_ArchaeologyUI.lua:150>

Locals:

List of races overflows window in BFA

It sort of runs under the new expansion so far, but among other things the list of archeology types spams outside the window now. I'm hoping it will be updated.