pharo-project/aleph

an index system for the pharo system

aleph's Issues

Last changes in Aleph makes large images build out of memory

It seems that the use of the GCConfiguration forLargeObjectAllocation in AlpIndexManager >> #start creates a too big usage of the memory. The GC is not triggered enough and use all the memory of the system to create the trie. The memory installed on the machine is 80GB.

Please revert the change.

CI should run tests of the whole image

With Aleph, we are hooking deeply into the system

We should not just run the Aleph tests, but all image tests in addition

Full blocks in the method literals make index building wrong

This method:

plop	
	[Object new ] value 

do not have #literals containing Object. It is just #().

As a consequence, the referencesOf:do: and sendersOf:do: gives incomplete results.
I'm not sure if the literals method should be changed to handle fullblocks or the references should be adapted.

Readme misses description how to install

It would be nice to have a description (code) how to load it

CI missing

It would be nice to have a CI setup

The implementation of `ClyVariableWritersQuery>>buildResult:` is incorrect

Aleph overrides the implementation of the method in ClyVariableReferencesQuery>>buildResult: in ClyVariableWritersQuery>>buildResult::

buildResult: aQueryResult
	| vars navigation |

	vars := variableQuery execute items.
	navigation := scope asSystemNavigation.
	aQueryResult fillWith: (((vars 
		collect: [ :each | navigation allReferencesTo: each ]) flattened) 
		select: [ :each | vars anySatisfy: [ :eachVar | each writesRef: eachVar ] ])

This causes the query (e.g executed when using the 'Writers' menu option in the context menu for instance variables) to always return an empty result. The main problem here is that (as far as I know) there is no index for references to instance variables (only one for references to classes). Besides that AlpSystemNavigation>>allReferencesTo: does not expect an object of class ClyInstanceVariable which leads it to, search in the senders index using the each object as the key in an IdentityDictionary (and predictably not find anything).

My idea would be to remove this method and use the default implementation in Pharo. I suspect ClyVariableReadersQuery>>buildResult: has the same problem, but I have not tested it.

Pharo10 broken: Missing method #takeFirst:

When loading with:

Metacello new 
	repository: 'github://pharo-project/Aleph/src';
	baseline: 'Aleph';
	load.

The tests fail due to a missing method #takeFirst:

Faling test on CI: #testFindingReaders #testFindingWritters

two tests are failing for both Pharo9 and Pharo10:

• #testFindingReaders
• #testFindingWritters

CI should run test for Pharo11

The CI setup for now just runs Pharo9 and Pharo10 (just the Aleph test).

We should run them for Pharo11, too