philipplackner/weatherapp

weatherapp's Issues

cuurent weather data returns null if the time in between 11 : 30 pm and 12 : 00 am

app/src/main/java/com/plcoding/weatherapp/data/mappers/WeatherMappers.kt

in the above file in the extension function toWeatherInfo

fun WeatherDto.toWeatherInfo(): WeatherInfo { val weatherDataMap = weatherData.toWeatherDataMap() val now = LocalDateTime.now() val currentWeatherData = weatherDataMap[0]?.find { val hour = if(now.minute < 30) now.hour else now.hour + 1 it.time.hour == hour } return WeatherInfo( weatherDataPerDay = weatherDataMap, currentWeatherData = currentWeatherData ) }

here if time is between 23 : 30 and 00:00 am it will return null cause since it is > 30 minutes it will go to hour plus 1 which is 24 but there is no 24th hour, it's 0th hour. So it will return null.

Location always return null

Location always return null : getCurrentLocation() if user just start device and launch app first .
Workaround : launch any app which request first location data properly first then launch WeatherApp.
So uncompleted location logic ;)

Icon source

Hello, could you tell me where you found the icons? Thanks!

Codebase as Template

Please, configure the settings of your tutorials repositories as TEMPLATES, so we can easily copy them