Giter Site home page Giter Site logo

docker-openjdk's People

Contributors

agterdenbos avatar bartgolsteijn avatar brend-smits avatar dependabot[bot] avatar eye2web avatar jeroenknoops avatar npalm avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

docker-openjdk's Issues

GitHub Actions requires user ROOT

Problem

Github Actions requires the user of the image to be ROOT otherwise it cannot checkout the repository.

Quick solution

Removing the java USER is possible, but it's also considered bad practice to create docker images with root.

Fix

In order to fix this issue, we will create a new docker-image with -gha (github actions) appended to the image tag.
The only difference with the original images are that they run with USER root

Images with USER root

In order to do this we need to do the following to images already running with user ROOT:

  • Create new docker-image based on the original with -gha appended to the tag and add deprecation warning to the original. (see #54)
  • After a week, add USER java to original image

Images with USER java

In order to do this we need to do the following to images already running with user JAVA:

  • Create new docker-image based on original image with USER: root and append tag with -gha.

This only applies to jdk images.

Add more precise tags with specific java version.

Currently we're tagging the images on a higher level. f.e. openjdk:11-jre and openjdk:11-jre-slim

This is nice, because now you can use openjdk:11-jre and we will take care of the updates.

But when you put stuff to production, you might pin the version down to a specific patch version of java, f.e. 11.0.1-jre-slim

Add this version as well, so environment can freeze their version of the image, making your production code immutable, thus reproducible.

Add java 8 jdk image.

We need to have a java 8 jdk image to for building our software.

JAVA_VERSION : 8u191

Add maven

Often projects use maven. Please add version with maven.

Images size is too big.

Images are very big.
This is caused by AWS-cli.

AWS-cli is used for:

  1. Build time: to push images to ECR
  2. Runtime for HIPAA ineligible services

Create seperate tags with and without AWS-cli

Append jdk images with `-gha` and add deprecation warning to original.

As part of #53 we need to perform the first step:

Create new docker-image based on the original with -gha appended to the tag and add deprecation warning to the original.

  • Create new image based on original with -gha appended to it.
  • Make sure the build order is correct to ensure the correct base image.
  • Add deprecation warning to original image.

Add java 11

Java has moved to version 11. Add this one

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.