phochmann/ctable

C library to print nicely formatted tables

ctable's Issues

Return value from `malloc_row` is not checked for NULL

The function malloc_row in src/table.c can return NULL if memory allocation fails:

https://github.com/PhilippHochmann/ctable/blob/e9ac72d79177474be4b28f7584f2e5aefc5f6f2e/src/table.c#L43-L46

The functions append_row and get_empty_table call malloc_row but do not check the return value for NULL:

https://github.com/PhilippHochmann/ctable/blob/e9ac72d79177474be4b28f7584f2e5aefc5f6f2e/src/table.c#L69-L79
https://github.com/PhilippHochmann/ctable/blob/e9ac72d79177474be4b28f7584f2e5aefc5f6f2e/src/table.c#L110-L123

Possible extension: fprint_table

The function void print_table(Table *table) prints to stdout.
stdout is like any FILE pointer though.
Possible new function could be void fprint_table(FILE *stream, Table *table) that does the same as print_table but a different FILE pointer can be specified.

The naming mirrors the relationship of printf and fprintf where fprintf is the same but allows any FILE pointer to be used.

vec_create function does not check malloc return value for NULL

The function vec_create calls malloc but does not check the return value for NULL:

https://github.com/PhilippHochmann/ctable/blob/e9ac72d79177474be4b28f7584f2e5aefc5f6f2e/src/vector.c#L25-L38

vec_create is called by strbuilder_create is called by add_cell_vfmt which can pass the NULL as the text argument to add_cell_internal where it is assigned to the text member of a Cell struct (last line below):

https://github.com/PhilippHochmann/ctable/blob/e9ac72d79177474be4b28f7584f2e5aefc5f6f2e/src/table.c#L15-L24

This seems to create a large separation between where the problem is created (NULL returned from malloc) and where the problem will be noticed.

Example source

The README should mention that the code to generate the tables in the example images can be seen in tests/test_table.c

Even better would be showing example usage code in the README.md or a standalone example file.