phongnguyen93/coderschool-week2

coderschool-week2's Issues

Thanks!

Hi @phongnguyen93, thank you for submitting assignment 2 .

Overall

• The apps run fine without any serious crashing.
• UI looks really polished and really cool looking. Good job
• Seems like the filtering tags still not working, could you please check it again?

Great stuffs

• Nice using RecyclerView and ButterKnife for binding and listing items.
• Nice using Retrofit for accessing New York Time API.
• Good job on using Glide for images .
• Great job on keeping things separate in each package, and code looks really clean. I like that
• Nicely define private for each variables.
• Those animations are really great, it looks cool. I like that

Area to Improve

• There are a lot of optional stories, you should do it. Because it will make you get better at programming android.
• You should implement class in, it will make your code looks more professional. Don't be like this :(.

Example

AutoCompleteTextView searchTextView = (AutoCompleteTextView) searchView.findViewById(
        "android.support.v7.appcompat" .R.id.search_src_text);

• If you have time you should help others with homework too <3. It would be great if you can help!.
• You should return something when there is no network connection or internet is not available, not just return No Results. It might be misunderstanding though :P.