Giter Site home page Giter Site logo

Comments (7)

rektdeckard avatar rektdeckard commented on April 28, 2024 1

We've decided to rename the icon Lemniscate, which is apparently another name for the symbol. It will continue to be available under the Infinity alias, bust since we aren't assigning anything to the Infinity global, this should serve you well and not break compatibility for existing users. Expect this patch in a day or two.

from react.

rektdeckard avatar rektdeckard commented on April 28, 2024 1

@power-f-GOD to clarify what I meant, we will be careful not to use global names internally, but it should not matter if we provided aliased named exports that occasionally conflict with globals.

from react.

rektdeckard avatar rektdeckard commented on April 28, 2024

Just use import aliasing to rename it to whatever you want. We have addressed this one before, andInfinity is not the only JS or web platform global that gets reused.

import { Infinity as InfinityIcon } from "@phosphor-icons/react”;

from react.

power-f-GOD avatar power-f-GOD commented on April 28, 2024

The error occurs during compilation (or should I say in the compiled/built code) independent of whether I'm using the icon or not.

Currently, I am not using the icon, I don't have it imported anywhere.

...Infinity is not the only JS or web platform global that gets reused.

That's not good practice, IMO. And even if the global must be "reused" (overridden), then they should, at least, have the same base (data) type.

Now, the compiler sees Infinity and reckons it is a number, but it is a RFC in this context.πŸ’”

from react.

markmssd avatar markmssd commented on April 28, 2024

We're running into the same issue, @power-f-GOD did you find a workaround? πŸ™πŸΌ

from react.

markmssd avatar markmssd commented on April 28, 2024

Thanks @rektdeckard ! Let's hope it helps 🀞🏼 As @power-f-GOD mentioned, even if the icon is not used, the error occurs during compilation (in our case, during Jest test runs). Let's see! πŸ₯

from react.

rektdeckard avatar rektdeckard commented on April 28, 2024

Try upgrading to@phosphor-icons/[email protected], should have fixed the issue

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.