php-bundles/json-request-bundle

Json Request Bundle

json-request-bundle's Issues

Question about disappearance

First and for al, thanks for providing this bundle!

But..., we noticed that this bundle was suddenly gone at the end of last year.
How did this happen, and can we count on it not happening again?

[copyright infringement] please rename your packages and organisation

Hello,

Naming your organization and your packages with "symfony" in the name might create confusion for the community.

Also Symfony is a trademark that must be used within the policy described at symfony.com/trademark

Please rename your organization and all related packages.

Thanks for your understanding.

Possibility to parse ld+json

Api Platform sends request in json+ld content type. it would be nice to parse those requests too.

getContentType method is deprecated as of Symfony 6.2

User Deprecated: Since symfony/http-foundation 6.2: The \"Symfony\\Component\\HttpFoundation\\Request::getContentType()\" method is deprecated, use \"getContentTypeFormat()\" instead.

Type hint: TreeBuilder does not released.

Looking at the code I saw that it was even merged but a new tag was not generated, see PR: #14

Method "Symfony\Component\Config\Definition\ConfigurationInterface::getConfigTreeBuilder()" might add "TreeBuilder" as a native return type declaration in the future. Do the same in implementation "SymfonyBundles\JsonRequestBundle\DependencyInjection\Configuration" now to avoid errors or add an explicit @return annotation to suppress this message.

Version 4.0.0 has event listener priority 0

Version 4.0.0 has default event listener priority 0, since in v.3.1.1 it was 100 and with new version bundle is not work

v.3.1.1
json-request-bundle-3.1.1\DependencyInjection\Configuration.php

        $rootNode
            ->children()
                ->arrayNode('listener')
                    ->addDefaultsIfNotSet()
                    ->children()
                        ->scalarNode('request_transformer')
                            ->defaultValue(RequestTransformerListener::class)
                        ->end()
                        ->scalarNode('priority')
                            ->defaultValue(100)
                        ->end()
                    ->end()
                ->end()
            ->end();

v.4.0.0
json-request-bundle-master\src\DependencyInjection\JsonRequestExtension.php

$listener->addTag('kernel.event_listener', ['event' => KernelEvents::REQUEST]);

Propose is modify
json-request-bundle-master\src\DependencyInjection\JsonRequestExtension.php

$listener->addTag('kernel.event_listener', ['event' => KernelEvents::REQUEST, 'priority' => 100]);

Support Symfony 4.4?

Since 4.4 is a LTS version, i think this bundle suppose to support it as well?

But my composer complaint it in 4.4:

- symfony-bundles/json-request-bundle[dev-master, 4.0.0, ..., 4.0.5] require symfony/framework-bundle ^5.0 -> found symfony/framework-bundle[v5.0.0-BETA1, ..., 5.4.x-dev] but it conflicts with your root composer.json require (4.4.*).