php-etl/rabbitmq-flow

rabbitmq-flow's Issues

Collision between current repo and configuration

Hello,

I'm in a trouble using this plugin on satellite because of some collisions. In the documentation, it's mentioned:

"This plugin is already integrated into the Satellite package, so you can’t require it with the composer."

But I don't find any dependency to this plugin in satellite main repository.
I solve it by require it manually: composer require php-etl/rabbitmq-flow

But I guess there is some delay between the current version and the configuration.
In Kiboko\Component\Flow\RabbitMQ\Rejection
Construct:

    public function __construct(
        private Client $connection,
        private string $stepUuid,
        private string $topic,
        private ?string $exchange = null,
    ) {
        $this->channel = $this->connection->channel();
        $this->channel->queueDeclare(
            queue: $this->topic,
            passive: false,
            durable: true,
            exclusive: false,
            autoDelete: true,
        );
    }

When the configuration is like this:

    rabbitmq:
        host: 127.0.0.1
        port: 5672
        user: 'guest'
        password: 'guest'
        vhost: /
        topic: product.api_rejects

Configuration seems to be based on the old version of the construct: 38ce28e

Could you tell me the good way to define MQ with Satellite ?

Thank you,

Didier

Use fastmap and nested node "map"

Hello,

We can't use nested nodes with fastmap configuration. This below example can't be executed:

- fastmap:
        expression_language:
          - 'Kiboko\Component\ExpressionLanguage\Akeneo\AkeneoFilterProvider'
        map:
          - field: '[translations][en_US]'
            expression: 'input'
            map:
              - field: '[name]'
                expression: 'input["identifier"] ~" | "~ attribute(input["values"]["variation_name"], locale("en_US"), scope(null, "ecommerce"))'
              - field: '[slug]'
                expression: 'input["identifier"]'
              - field: '[description]'
                expression: 'attribute(input["values"]["description"], locale("en_US"), scope("ecommerce"))'

The error :

Invalid configuration for path "etl.satellite.pipeline.steps.1.fastmap.map.1": Your configuration should either con
tain the "expression" or the "map" field, not both.

It's related to this node part of the configuration:

 map:
          - field: '[translations][en_US]'
            expression: 'input'
            map:

I don't find any hints on the code source or in documentation to solve this.

Thank you !

Didier

Order of load method arguments

Hello,

I have a trouble with the load method :

while (true) {
    $this->channel->publish(
        \json_encode($line, JSON_THROW_ON_ERROR),
        [
            'content-type' => 'application/json',
        ],
        $this->topic,
        $this->exchange, 
    );

    $line = yield new AcceptanceResultBucket($line);
}

The publish method :

public function publish($body, array $headers = [], $exchange = '', $routingKey = '', $mandatory = false, $immediate = false)

The topic and exchange arguments are reversed.

Thank you,

Geoffrey