Giter Site home page Giter Site logo

Comments (4)

malkusch avatar malkusch commented on June 3, 2024

I use the @internal annotation to mark

that the associated Structural Elements are used purely for the internal workings of this piece of software.

In particular to avoid apearing such internal details in the API documentation.

I actually don't need those abstract methods in the trait. I have them there for convenience, so that the code makes sense while calling those methods from the expected PHPUnit API.

But for you as a PHPUnit user they are part of the public API of PHPUnit. Actually I don't know what should be a correct behaviour for this case. I don't think it's well defined in PHPDoc and last time I checked, this FIG soap was about to implode or at least PSR-5 died. Ok, before I make any action on that, I need some authoritative information about the correct behaviour. I'll try to get that from https://github.com/phpDocumentor/phpDocumentor2.

from php-mock-phpunit.

emirb avatar emirb commented on June 3, 2024

@malkusch Can you fully remove those abstract methods in the trait, as you said you don't need them actually? They add no value and just pollute inspections in PhpStorm.

from php-mock-phpunit.

michalbundyra avatar michalbundyra commented on June 3, 2024

@emirb Please see #27, methods from trait are there removed.

from php-mock-phpunit.

emirb avatar emirb commented on June 3, 2024

Thanks @webimpress!

from php-mock-phpunit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.