phpmessagebus/messagebus

A MessageBus (CommandBus, EventBus and QueryBus) implementation in PHP7

messagebus's Issues

Busses do not function properly without additional middleware

I'm testing out this library in a project of mine. I was having problems with QueryBus returning an EmtpyResponse no matter what I did, but after looking at the code it seems that adding middleware in addition to QueryBusMiddleware causes it to function properly and return the correct response.

I haven't tested the other busses yet, but it looks like they all use $current = array_shift($middleware);, which, if you're only using the "core" middleware and nothing else, empties $middleware and the following foreach does not run.

Did I miss something in the docs or is this not the intention?

Improve error message

 "message": "Type error: Return value of NilPortugues\\MessageBus\\CommandBus\\Resolver\\SymfonyContainerResolver::instantiate() must be an instance of NilPortugues\\MessageBus\\CommandBus\\Contracts\\CommandHandler, instance of Modules\\Forum\\Domain\\Services\\TopicDeleterCommandHandler returned"

The following error message would be a bit more clear, could you add it please?

"Make sure that the class TopicDeleterCommandHandler extends from CommandHandler"

Documentation is not using ContainerInterop

It's using the Silex format instead. So it needs fixing.

Not too dramatic, but it's just wrong!

Provide generic Command, Event and Query implementations

Because DTO are easy to use, but I require passing an object implementing an Interface, provide helper objects. For instance:

<?php
use NilPortugues\MessageBus\CommandBus\Contracts\Command as CommandInterface;

class Command implements CommandInterface
{
    public function __get($property) 
    {
            if (property_exists($this, $property)) {
                return $this->$property;
            }
    }

    public function __set($property, $value) 
    {
            $this->$property = $value;
    }
}

Factory for MessageBus

According to many users it will be a nice addition.

Discussion has been carried here: https://www.reddit.com/r/PHP/comments/4f6pb1/phpmessagebusmessagebus/