Giter Site home page Giter Site logo

Comments (4)

drupol avatar drupol commented on July 19, 2024 1

Oops, looks like I totally forgot about this, sorry!!!!

Thanks for explanation, I've finally found a way to use it as it should be used :)

from grumphp.

veewee avatar veewee commented on July 19, 2024

Not sure what you are trying to achieve here. Can you elaborate in more details?

You can run grumphp without .git if you pass in the list of files you want to check through STDIN (as a list of files) or if you pass in a git diff.

How would you want to pass the files instead if you don't have a .git?

from grumphp.

drupol avatar drupol commented on July 19, 2024

mmhm sorry to hear read that.

Essentially, the initial request involves using Grumphp as a task runner when the .git directory is not provided. In this scenario, it would execute the commands without requiring a .git directory to be present.

Consider the phpcsfixer task as an example. When the .git directory is available, Grumphp will supply the phpcsfixer task with a list of modified files.

However, when the .git directory is not available, no specific files will be passed to the task. In this case, the phpcsfixer task will continue to work, and will potentially scan the src directory (or other designated directories in its default config), and thus behaving in a more generalized manner.

This flexibility allows for the continued use of the task runner even in environments where the .git directory might be absent or inaccessible.

from grumphp.

veewee avatar veewee commented on July 19, 2024

As you know, everything is possible and up for discussion.
But to be fair: this is how the internal system was designed from day one and always has worked.
You are simply trying to achieve things for which this tool is not designed.

The big problem I can see here by not passing any files is:
If you don't pass any files, a lot of tasks will skip because there are e.g. no PHP files provided.
This is the logic that makes GrumPHP only run the tasks that are needed based on the git diff in a pre-commit.

A possible solution would be to read all the files of the project's directory.
However, you most likely don't want to include things like vendor, node_modules, application caches, ....
So that means you'll need ways to include or exclude folders, files, ...
That would probably be a lot of work - just to make it work outside of .git context.
That is basically why it works the way it works nowadays: git already offers the project included / excluded files and the list of all known files.

I'm not sure if this feature could make it to grumphp's core and am most surely not going to create it myself at this moment :)

from grumphp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.