Grumphp config using default PHPCS XML and other standard's sniff

[carltondickson]

Grumphp config using default PHPCS XML and other standard's sniff

[carltondickson]

@veewee thanks for your response, it helped me get to the issue.

I went through the process with a new project and could see that the call to phpcs looked fine after debugging grumphp commandline that was created.

As I was stripping out old phpcs config and directories I deleted <config name="ignore_errors_on_exit" value="1"/> and think this was the issue.

https://github.com/squizlabs/PHP_CodeSniffer/wiki/Configuration-Options#ignoring-errors-when-generating-the-exit-code

I ported CLI args from our build --runtime-set ignore_warnings_on_exit 1 --runtime-set ignore_errors_on_exit 1 to a .phpcs.xml config file a long time ago which is why I think they are in there.

I think this flag was initially added because phpcs wasn't reporting to Github (will need to investigate this)

[veewee]

Hello @carltondickson,

GrumPHP only passes the arguments to phpcs. So assuming you don't provide any standard in grumphp, it will take the standards that are defined in the configuration file. I'm not sure what is going wrong with the given information.

Can you debug what phpcs command is being executed exactly from grumphp and what happens if you run that exact same command with phpcs directly?

You should be able to figure it out by:

• disabling parallel mode and use the -vvv flag on grumphp run
• echoing it inside the php file

  grumphp/src/Task/Phpcs.php

  Line 97 in 813e865

  return $this->processBuilder->buildProcess($arguments);

That should give you the same results and a starting point from where to figure out what is going wrong.