Passing an array as $methodNames argument in LegacyMockerInterface::shouldReceive() results in error

[phpstan]

Passing an array as $methodNames argument in LegacyMockerInterface::shouldReceive() results in error

[ondrejmirtes]

Should be just a matter of updating the stubs: https://github.com/phpstan/phpstan-mockery/blob/master/stubs/MockInterface.stub

[wimski]

So that isn't supported in the current stub that comes with this package?

[ondrejmirtes]

Nope, string[] ...$methodNames means that the variadic argument accepts string.

[wimski]

Are you planning to update the stub to use string[]|array to match the signature of the LegacyMockInterface?

[ondrejmirtes]

@wimski You can send a PR by yourself :) I'd recommend string[]|array<array<string, mixed>>.

[wimski]

I will, but shouldn't it be string|array<string, mixed> ...$methodNames?

https://github.com/mockery/mockery/blob/14a510d1997d8e139a4414faea988d528ffc29ba/library/Mockery/LegacyMockInterface.php#L37

// LegacyMockInterface

/**
 * Set expected method calls
 *
 * @param string|array ...$methodNames one or many methods that are expected to be called in this mock
 *
 * @return \Mockery\ExpectationInterface|\Mockery\Expectation|\Mockery\HigherOrderMessage
 */
public function shouldReceive(...$methodNames);

[ondrejmirtes]

Try and test it.

[wimski]

#24

[ondrejmirtes]

Fixed by #24.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.