Infer mock type when defined in setUp

[phpstan]

Infer mock type when defined in setUp

[ondrejmirtes]

Hi, this works exactly as it's supposed to. When PHP does not allow you to define the precise property type via native types, you need to add a PHPDoc.

The correct way to typehint this is MockInterface&Foo, see the differences between union types and intersection types: https://phpstan.org/blog/union-types-vs-intersection-types

There's a hardcoded exception so that MockInterface|Foo is also interpreted as an intersection type because that's what people mean when they write that.

I don't plan to infer the assigned type from the setUp() method, that's not what the extensions support.

[ruudk]

Thanks for the explanation.

There's a hardcoded exception so that MockInterface|Foo is also interpreted as an intersection type because that's what people mean when they write that.

Btw, I was aware of the intersection typing. Somehow people keep on adding the union types in our codebase. Would it be possible to make this configurable? So that you can only use intersect? (willing to create the PR if you agree).

[ondrejmirtes]

Would it be possible to make this configurable?

Yes, it's easy.

1. Create a new bool parameter for this.
2. Remove the tag from this service definiton:

   phpstan-mockery/extension.neon

   Lines 60 to 63 in 053bf9e

   	-
   	class: PHPStan\Mockery\PhpDoc\TypeNodeResolverExtension
   	tags:
   	- phpstan.phpDoc.typeNodeResolverExtension

3. Create a new conditionalTags section like here: https://github.com/phpstan/phpstan-src/blob/6f7cadf96c7b55a0df21b51730e4b53ad13a7545/conf/config.level4.neon#L20-L30

[ruudk]

@ondrejmirtes Like this #28 :D ?

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.