phylogeny/proportionaldestructionparticles

A client-side mod that causes block destruction particles to only spawn in blocks' collision/bounding boxes.

proportionaldestructionparticles's Issues

Crash with loading world

Describe the bug
Use FancyBlockParticles and ProportionalDestructionParticles.

Crash report
https://pastebin.com/ehxja53X
https://pastebin.com/NDwped7Y

To Reproduce
Just loading a world.

• Mod Version: 1.2.1
• Forge: 14.23.5.2768
• FBP: 2.4.1

Incompatibility with upcoming version 2.4.1 of FBP

I renamed every field, method and label related to the animation/particle Exceptions. I don't know why I couldn't find the right word for this feature... so I renamed it to a Blacklist.

About the incompatibility..
I destroyed a block and my game crashed because your mod is looking for a specifically named method which will be renamed in the upcoming version 2.4.1 of FBP.

Here's the crashlog:
https://pastebin.com/kwHd7gKp

Keep this 'issue' as a note for the future versions of your mod.
You can check how I renamed the methods here: https://github.com/TominoCZ/FancyBlockParticles/blob/master/src_1.12.x/main/java/com/TominoCZ/FBP/FBP.java#L214

Crash w/ Little Tiles

Minecraft v1.12.2
Forge v14.23.5.2128
Little Tiles v1.5.0-pre130
Proportional Destruction Particles v1.2.4

I got a crash after trying to break a Little Tiles block with an empty hand, created with the little tiles recipe item.
I reported this back in March on the Curseforge page, but I just noticed the GitHub page, so I thought I would try reporting it here.
Crash Report

Grey particles with the Leaves block and others

This also happens with grass and other blocks that have a color multiplier for particles.
While looking at your code, I compared the 2 ParticleManagers and I noticed one thing that is actually quite important :D

In ParticleManagerMod, you call .setBlockPos(pos) when you create the new particle (here), but you don't in FBPParticleManagerMod (here).

The method .setBlockPos(pos) actually does't only set a private position variable in the particle, but it also applies the color multiplier of the block to the color channels of the particle (so that leaf particles aren't grey :D).

I actually made a similar mistake in my mod in versions 2.4.0 and older, not calling this method.. But fixed it in the new version 2.4.1.

I overrode .setBlockPos(pos) in FBPParticleDigging in 2.4.1 (so that it returns FBPParticleDigging and not ParticleDigging).

ProportionalDestructionParticles.CLIENT_OLNY is spelled wrong

Just thought you might like to know.