Top blocked domains should not return duplicates and sort descending

[yubiuser]

Top blocked domains should not return duplicates and sort descending

[yubiuser]

Restating FTL fixed it.

[rdwebdesign]

Maybe this was caused by another branch test...

When you test different branches, are you using the same database or a total clean installation (or container)?

[yubiuser]

Same database. My v6 is running bare metal. If I delete the database every time I have no queries to play with.

[DL6ER]

Looking at this before I even opened the code is: Maybe there have only been two domains in your history. FTL first collects the domains and then sorts them by ID. So the result may have been 0,1 and the rest of the array was (by initialization) still at 0,0,0,0,0,0,0,0 leasing to what you are seeing here.

...

While looking at the code: That's only part of the answer. There is code to prevent exactly this, actually. However, this is kind-of a regression of #1694 because we can have recycled domains not being eligible for inclusion here but still counting towards the total number of records we can return.