After refactor, page refreshes on form submit in specific cases

[slannigan]

After refactor, page refreshes on form submit in specific cases

[GCorbel]

You're right, this is a bug. I'm very sorry for that. It was a big refactoring and I did some mistakes.

Let me know if you have other problems.

Do you want to do a PR ? I can do it if you don't want.

[slannigan]

If you have time to look at it within the next day, that'd be great, since you know more about the context and probably have a better idea of how to fix it. If you don't have time I'd be happy to take a look!

[GCorbel]

I'll do it. It should not be complicated.

[GCorbel]

I created #161 . It should fix the issue Please, can you test it ? I will merge once I have your confirmation.

[slannigan]

I tested #161 against my test repo (https://github.com/slannigan/em-forms-refactor-bug), and unfortunately the last two forms are still causing the page to refresh on submit!

[spruce]

I will wait to merge the PR until this is fixed, ok @GCorbel ?

[GCorbel]

@slannigan @spruce I'll check it tonight.

[slannigan]

Ok, thanks! If I can be of help let me know.

[GCorbel]

It works now. I tried with your project but please, give me a confirmation.

Don't forget to replace the version with "ember-rapid-forms": "https://github.com/GCorbel/ember-rapid-forms/tarball/6804704853127521c72f8814741d88a40e72fe36" in your package.json.

[slannigan]

I tested "https://github.com/GCorbel/ember-rapid-forms/tarball/6804704853127521c72f8814741d88a40e72fe36" against many of our site's forms, and it works great! Thanks for your fix!

[GCorbel]

awesome. I'll merge the PR and I close this issue.