Comments (2)
Here is the event I've added that is triggered on body, its name is guiders-close
.
diff --git a/static/js/libraries/guiders-1.2.8.js b/static/js/libraries/guiders-1.2.8.js
index a5f970b..90ec37a 100644
--- a/static/js/libraries/guiders-1.2.8.js
+++ b/static/js/libraries/guiders-1.2.8.js
@@ -116,6 +116,7 @@ var guiders = (function($) {
guiders.hideAll();
if (myGuider.onClose) {
myGuider.onClose(myGuider, false /* close by button */);
+ $('body').trigger("guiders-close");
}
});
break;
@@ -153,7 +154,8 @@ var guiders = (function($) {
guiders.hideAll();
if (myGuider.onClose) {
myGuider.onClose(myGuider, true);
- }
+ $('body').trigger("guiders-close");
+ }
});
};
@@ -163,6 +165,7 @@ var guiders = (function($) {
guiders.hideAll();
if (myGuider.onClose) {
myGuider.onClose(myGuider, true /*close by X/Escape*/);
+ $('body').trigger("guiders-close");
}
return false;
}
Cheers,
Miguel
from guiders-js.
Thanks Miguel. I am going to use this, but with camelCase instead of hyphens. Also, I'm not going to merge directly into master anymore. I just created a dev branch. This way I'll be able to merge pull requests to dev without screwing up master, while working on a new version.
from guiders-js.
Related Issues (20)
- README says "prev" but the special name value for a back button is "back" HOT 4
- Vertical positioning doesn't take margins into account
- z-index values are ridiculous HOT 1
- Buttons duplication when the tour run second time HOT 3
- Highlight does not work unless attachTo is specified HOT 2
- issue with dehighlightElement
- button onclick runs immediately HOT 1
- One help/tour link to rule all tabs HOT 1
- Responsive design improvement suggestion
- Returning guider on next and prev methods HOT 1
- Add a changelog HOT 3
- Tag releases HOT 5
- Whenever something is loading, display the loading animation (non-priority)
- Highlight does not work with divs HOT 5
- Unobtrusive Fork of Guiders.js HOT 4
- Events should be namespaced
- IE8/9 overlay set to absolute
- Arrows not shown under IE7 HOT 1
- Respond appropriately to screen edge HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from guiders-js.