pie-dao/dough-staking

Solidity contracts for distribution of governance mining rewards

dough-staking's Issues

Initialiser instead of constructor

(possibly use diamond storage for easier upgradeability)

Allow only whitelisted contracts to interact with SharesTimeLock.sol

The account which locks the tokens cannot be a smart contract in order to avoid making it tradable, unless it is one of the whitelisted smart contracts (such as widely used multi-sig wallets or yearn).

Events

• Eject
• boostToMax
• distribute
• collectWithParticipation
• collectForWithParticipation

Assume block are 12s

Adding relevant comments to the functions

Test `eject` function

https://github.com/MickdeGraaf/dividends/blob/dough-staking-poc/contracts/SharesTimeLock.sol#L171

Assume block are 12s

The block time for the upcoming Ethereum 2.0 (Eth2) is set to 12 seconds. This includes the beacon chain and shard chains.

Rename

Everything named as dividend should become reward.

Improve Events Data

in order to properly sync with thegraph, we are in need to have a complete set of infos coming from events.
In details, we should modify the events BoostedToMax / Deposited / Withdrawn / Ejected by adding the lockID value to the emitter.

canEject needs to take in consideration already ejected locks

Test `redistribute` function

https://github.com/MickdeGraaf/dividends/blob/dough-staking-poc/contracts/ERC20NonTransferableRewardsOwned.sol

Consider adding a buffer to the eject function of week.

If I did stake and participated in the last month of my lock I could be ejected one second after my lock and then I lose my rewards.

A possible solution, add a week to the buffer.

Pre audit checklist

• Remove console.logs
• Events (eject, redistribute, etc)
• Remove unused testing contracts
• Run coverage
• Deployment scripts
• Possible gas savings

Full Integration test

• Deploy the Timelock
• Deploy the ERC20 Non-Transferable Token
• Let the time pass
• Set Merkle Proof
• Verify the outcomes

Cases to cover:

• Multiple accounts at the same time
• One account at the same time
• User who did not partecipate is not able to claim
• User who was ejected cannot claim rewards
• User who did partecipate is able to claim
• User that have have his lock expired can be ejected

README