pierre-lannoy/wp-keys-master

Powerful application passwords manager for WordPress with role-based usage control and full analytics reporting capabilities.

wp-keys-master's Issues

PHP 8.1 warnings and deprecations

Describe the bug
Thanks to Decalog, we've caught some errors of Keys Master from the event log.

Error (E_WARNING): “Undefined variable $idle“ at `./wp-content/plugins/keys-master/includes/system/class-password.php:471`.
Error (E_DEPRECATED): “round(): Passing null to parameter #1 ($num) of type int|float is deprecated“ at `./wp-content/plugins/keys-master/includes/features/class-analytics.php:779`. # also on some other lines

Expected behavior
PHP errors are annoying, even for deprecations that isn't really an "error".

Screenshots

# Site Frontend
0 shutdown_action_hook()
       [PHP Kernel]
1  do_action(`shutdown`)
       ./wp-includes/load.php:1144
2  WP_Hook->do_action(Array)
       ./wp-includes/plugin.php:517
3  WP_Hook->apply_filters(``, Array)
       ./wp-includes/class-wp-hook.php:332
4  KeysMaster\Plugin\Feature\ZooKeeper::execute_tasks(``)
       ./wp-includes/class-wp-hook.php:308
5  KeysMaster\Plugin\Feature\ZooKeeper::revoke_old_passwords()
       ./wp-content/plugins/keys-master/includes/features/class-zookeeper.php:59
6  KeysMaster\System\Password::auto_revoke_password(Array, 1)
       ./wp-content/plugins/keys-master/includes/features/class-zookeeper.php:94

# Site backend
0  require_once(`/var/www/blog/wp-load.php`)
       ./wp-admin/admin.php:34
1  require_once(`/var/www/blog/wp-config.php`)
       ./wp-load.php:50
2  require_once(`/var/www/blog/wp-settings.php`)
       ./wp-config.php:125
3  include_once(`/var/www/blog/wp-content/plugins/keys-master/keys-master.php`)
       ./wp-settings.php:453
4  pokm_run()
       ./wp-content/plugins/keys-master/keys-master.php:83
5  KeysMaster\Plugin\Core->__construct()
       ./wp-content/plugins/keys-master/keys-master.php:76
6  KeysMaster\Plugin\Core->define_metrics()
       ./wp-content/plugins/keys-master/includes/plugin/class-core.php:62
7  KeysMaster\Plugin\Feature\Analytics::get_status_kpi_collection(Array)
       ./wp-content/plugins/keys-master/includes/plugin/class-core.php:135
8  round(``, 2)
       ./wp-content/plugins/keys-master/includes/features/class-analytics.php:779

Environment (please complete the following information):

• PHP version: 8.1.15
• WordPress version: 6.2
• Other info: Decalog event

Weird and random uncaught error

Describe the bug
The plugin throws an uncaught error randomly. Since this is not observed in the frontend (only found in server logs), I suppose it is only triggered by cron or AJAX.

To Reproduce
Wait for it happens😂

Expected behavior
Error-free is best:)

Screenshots

PHP message: PHP Fatal error:  Uncaught Error: Call to a member function get_privileges_for_user() on null in /var/www/blog/wp-content/plugins/keys-master/includes/system/class-password.php:463
Stack trace:
#0 /var/www/blog/wp-content/plugins/keys-master/includes/features/class-zookeeper.php(94): KeysMaster\System\Password::auto_revoke_password()
#1 /var/www/blog/wp-content/plugins/keys-master/includes/features/class-zookeeper.php(59): KeysMaster\Plugin\Feature\ZooKeeper::revoke_old_passwords()
#2 /var/www/blog/wp-includes/class-wp-hook.php(308): KeysMaster\Plugin\Feature\ZooKeeper::execute_tasks()
#3 /var/www/blog/wp-includes/class-wp-hook.php(332): WP_Hook->apply_filters()
#4 /var/www/blog/wp-includes/plugin.php(517): WP_Hook->do_action()
#5 /var/www/blog/wp-includes/load.php(1144): do_action()
#6 [internal function]: shutdown_action_hook()
#7 {main}
  thrown in /var/www/blog/wp-content/plugins/keys-master/includes/system/class-password.php on line 463

Environment (please complete the following information):

• PHP version: 8.1.15
• WordPress version: 6.2
• Other info: W3TC enabled (not sure if involved)