pierreelias/introecg

Resource library for getting started with deep learning work using electrocardiograms

introecg's Issues

ecg_simulate outdated in neurokit2

It seems that
nk.ecg_simulate(duration=para.duration*2, sampling_rate=para.sampling_rate, noise=noise, Anoise=para.Anoise, heart_rate=hr, gamma=para.gamma, ti=ti, ai=ai, bi=bi)
in ecg_simulation.py does not work.

The ecg_simulate function in neurokit2 does not support the same parameters any more.
Could you tell me which version of neurokit2 do you use? Or is there a simple fix?

Thank you very much!

Why is signaly of the calibration marker used as scale value?

Thank you for this great work!

I was wondering why the y component of the signal from the calibration marker is used to scale both X and Y component of the leads. If I read your code correctly, np.min(signaly) of the marker will be used to scale X and np.max(signaly) will be used to scale Y. Although I see the point in scaling the y component Y of the leads by Y dimension of the marker, I don't understand why the X component of the leads should be scaled by the Y component of the marker.

Would you mind detailing your reasoning for this?

IntroECG/1-Waveform Extraction/ecg_pdf_to_dataframe.py

Line 150 in b728633

scale_vals.append([np.min(signaly), np.max(signaly)])