pierreglaser/folding-nvim

folding-nvim's Issues

Telescope folding

If the foldinglevel is not set to a high number Telescope window is folded.

Fold on opening/writing buffer

Hello, is it possible to disable folding when opening/writing a buffer? Right now it is being done automatically. I tried ( in the lua/folding.lua file ) commenting out the M.update_folds() method after M.setup_plugin(), but then it never finds any fold afterwards.

Folds all regions when file is opened

Does the package immediately folds all regions when the file is opened? Because this is happening on my machine. If this is an intentional behaviour, can it be disabled? I'm using this package for Typescript files.

have `folding-nvim` ask folds only to user-specified `clients`

As suggested by @ajitid in #6 (comment)_

Unrelated, but another change I made is to only attach to those clients into which I've specified ajitid@6de3bb5. This reduces the nagging on upon opening each file.

It would be nice to be able to tell folding-nvim which client to ask folds for, in order to be able to suppress the <client> does not support folding requests warning messages sent by the plugin.

New LSP request callback signature incompatible

Hello!

I noticed this plugin stopped working for me a little while ago, and, after a bit of debugging, I noticed that the LSP request callback handler M.fold_handler() has a method signature that is different than the signature specified in the documentation:

folding-nvim:

  function M.fold_handler(_, _, result, _, bufnr)

:h lsp-handler:

  function(err, result, ctx, config)

I've seen some of the newest NeoVim updates breaking a lot of LSP plugins lately, and, when I checked, that's what I think happened. The issue seems to come from bufnr being nil. Supposedly, ctx['bufnr'] is where the new buffer number value should come from. So I changed that and moved the result parameter to match the doc.

So, all in all, what made it work for me was doing this:

  function M.fold_handler(_, result, ctx, _)
      local bufnr = ctx['bufnr']
  ...

I am by no means an expert when it comes to this stuff, but I hope this helps!