The bitcoin-acks from pierrerochard

Create a separate "detailed overview" tab

This detailed overview tab would include more information even if it results in a wider table

Script and tools label is unreadable

Awesome project!

See attached screenshot. The label Scripts and tools is unreadable

Enable searching the ACKs column for specific users

Currently the ACKs column is implemented as a count that is then masked by the formatter to display the user names. This prevents searching by user name

CI Status missing for most PRs

The CI column is empty for almost all PRs. This breaks the "Ready for Review" and "Ready for Maintainers" buttons since those default filters include CI status. I would guess that this is caused by the switch to Cirrus that we did a while back.

Author name not shown in detail view

Open any PR into the detail view, i.e https://bitcoinacks.com/details/?url=%2F&id=MDExOlB1bGxSZXF1ZXN0MTg1MzA0NzUx

The "Author" will be displayed as <bitcoin_acks.models.users.Users object at ...>

Update legend to align with current Bitcoin Core review guidelines

Posting this in case someone else gets to this before I do.

Currently bitcoinacks.com has a legend of Concept ACK, Tested ACK, Stale Tested ACK, utACK, Stale utACK, NACK.

The Bitcoin Core review guidelines were updated last year and now encourage use of Concept (N)ACK, Approach (N)ACK and ACK branch_commit.

To follow these guidelines we need to ditch Tested ACK, Stale Tested ACK, utACK, Stale utACK in the legend and introduce Approach ACK, ACK commit, Stale ACK commit.

(Of course reviewers are still encouraged to describe what testing they have done in their review. But in a descriptive comment rather than standardized use of tACK, utACK. We could perhaps monitor whether the reviewer mentions "test" in their comment. But I'm leaning towards not as reviewer could state something "Did not test" and it might be wrongly flagged as the equivalent of a tACK)

Implement BitcoinPulls bot

Non-stale utACK shows as Stale utACK

In bitcoin/bitcoin#10973. I reviewed the latest commit e44e639558b1084f14a97847592616c3df9fff38 and typed it in the comment. It should show as utACK on bitcoinacks.com, however it shows stale ack.

Label filters don't seem to be working

Automatically review merged PRs from high priority

This should be automatic with the existing code, but it is not, so there's a bug somewhere

Incorporate bitcoin-core/gui repository when user looks for GUI PRs or click on "User-Interface Only" label

Perhaps this is too obvious, since all the GUI stuff moved to bitcoin-core/gui respository, but just found this website/ tool which I find quite useful.
Not sure how difficult would be to merge the queries & results or maybe just look into one repository or the other.

User should be able to login with github oauth to have a custom list

ACK appears as stale ACK

The ACK here is parsed as a stale ACK.

Related to fixed issue #76? Perhaps stale status should also require new commits to exist further down in the HTML than the ACK if it doesn't provide a commit hash (hacky, I know).

Links to ACK comments are broken

The links to the individual ACK comments are to the wrong domain (bitcoinacks.com rather than github.com) and without slashes. E.g. https://bitcoinacks.com/httpsgithubcombitcoinbitcoinpull21702pullrequestreview1117997387

High priority PRs contains old PRs...

instead of only the PRs in https://github.com/bitcoin/bitcoin/projects/8.

"untested ack" should be be parsed as utack, not ack

see bitcoin/bitcoin#12404 (comment)

Feature request: Recently updated sort that ignores bots

Possible feature request from IRC discussion. Maybe bitcoin-acks can provided a list of recently updated PRs that ignores DrahtBot comments:

<gmaxwell> breaking sort by recently updated has probably reduced the amount of review I do by 80%, FWIW.
<gmaxwell> as I'd typical go and sort by updated and check in on all the active PRs.
<wumpus> luke-jr: yes that would be preferable, but I do not know if github provides that functionality to random developers, lacking that, sipa's idea to post once then update is a good idea
<sipa> actually, a top comment that gets updated may not be enough to un-break it; the PRs that get newly referenced by another post's "conflicts with" will still be marked as recently updated
<gmaxwell> another alternative would be to just post some external thing with the real recently updated data.
<gmaxwell> e.g. go scrap github or new commits every couple hours and post a report somewhere.
<gmaxwell> scrape*
<wumpus> gmaxwell: ah yes kind of what bitcoinacks.com does

Implement BitcoinTags bot

https://twitter.com/CryptoPietje/status/907684709865607169

Implement BitcoinHasIssues bot

Show Concept ACK

Have a column for Concept ACK | utACK | Tested ACK...

Automate high priority

I'm currently manually entering it in the DB based on what's here https://github.com/bitcoin/bitcoin/projects/8

Should be automatable

High Priority to Review is outdated

The PRs tagged as High Priority for Review does not match the project board: https://github.com/orgs/bitcoin/projects/1

I would guess that this was caused by a switch from Github's old projects system to the new projects system.

Sorting by most recently updated seems broken

Nice job with this. Site is great!

I noticed if I click "updated" column header in order to see the most recently updated PR's, the resulting sort order seems kind of random. Would be nice if this worked, since I often use "sort:updated-desc" term in github to check active prs.

GitHub data not up to date

It looks to me like the most recent PR that can be found on bitcoinacks.com currently is #20030 (which is about 5 days old) while on GitHub the newest PR is #20074.

Is it possible that since the changes in b037d7f the CLI data update doesn't work anymore?

Be able to filter by ACK type

Currently there's no way to filter reviews by ACK type, all ACK types are bundled together. As a maintainer, I would find it more useful to be able to ignore PRs that only have e.g. Stale ACKs, or do not have some number of current Tested ACKs.

Number of columns, table is becoming too wide

The table is becoming too wide. A good thing about an overview site is when it provides an overview at one glance.

Splitting the different types of ACKs into different columns (#44) is a nice idea, but it makes it hard to browse the list here without horizontal scrolling. I could distinguish them based on color quite well.

reACK incorrectly detected as Concept ACK

reACKs are being detected as Concept ACKs when they should be Tested ACKs if followed by a commit hash.

Example: bitcoin/bitcoin#19762 (review)

Some ACKs missing from PRs

See 10757 for example. bitcoinacks.com shows just a single concept ACK. It's missing these:

utACK from ryanofsky: bitcoin/bitcoin#10757 (review)
ACK from jimpo: bitcoin/bitcoin#10757 (comment)

I can't load this PR in my browser and get the unicorn. Perhaps that's also causing issues for bitoinacks?

External links should open new window

External links should be target=blank

Website certificate expired

The Let's Encrypt certificate for https://bitcoinacks.com expired on 17 August.

Please renew it, thanks.

add https://github.com/bitcoin-core/gui to the website

GUI dev has gained momentum since the creation of https://github.com/bitcoin-core/gui
Please add to the website...it may help the GUI dev process...

Track finalized pledges

Would it mess with incentives if the amount of pledges payed as displayed?

As a user, I think it could be interesting to track how much was committed as opposed to just promised. If not the totals donated by all users, at least my own totals.

Concept NACK shows up as ACK?

I noticed that MarcoFalke had concept nack'ed PR bitcoin/bitcoin#12360, but he showed up in the ACK column.

Filter closed/merged PRs when sorting via ACKs

When sorting via ACKs (https://bitcoinacks.com/?desc=1&sort=7), it'd be good to filter out closed or already merged PRs.

Remove "Needs rebase" labels when they are removed on GH

It seems that the "Nees rebase" labels don't get removed when they are removed on Github. In this case, it is pretty critical that this happens because potential reviewers might wait to start a review until a PR has been rebased because otherwise they are guaranteed that the need to re-review after the rebase again.

Limit body text length

Saw this today

Labels are not updated when removed

reported by @skeees

Hide closed and merged PRs?

As I use bitcoinacks to find things to merge, one of the most common things I want to do is hide PRs that:

Are already merged
Are closed
Are currently unmergeable (but this is less important)

It's possible to do this with the current filtering, but I keep having to set it up time after time, it would be useful to have stored queries or such, I dunno.

Celebrate first time contributor merges

500: INTERNAL SERVER ERROR

$ wget https://bitcoinacks.com/
--2019-06-17 06:27:25--  https://bitcoinacks.com/
Resolving bitcoinacks.com (bitcoinacks.com)... 34.194.132.158
Connecting to bitcoinacks.com (bitcoinacks.com)|34.194.132.158|:443... connected.
HTTP request sent, awaiting response... 500 INTERNAL SERVER ERROR
2019-06-17 06:27:25 ERROR 500: INTERNAL SERVER ERROR.

Words including the substring “tack” counted falsely as tested acks

I noticed that linking to Bitcoin Stack Exchange in an issue comment is counted as a “tACK”. Possibly the evaluation should be checking whether the “tack” is preceded by a whitespace character or the beginning of the message.

screenshot via bitcoin/bitcoin#26525 (comment)

cc: @vostrnad

Improve workflow for maintainers

This is maybe an overbroad issue, but it seems Bitcoin maintainers are currently struggling to keep track of open bitcoin PRs. From today's IRC meeting: "I can't manually, humanly, handle 200+ PRs, sorry" (https://botbot.me/freenode/bitcoin-core-dev/msg/104301215/).

I'm wondering if it would be possible to add features to bitcoin-acks that could improve maintainer workflow. Two examples that come to mind:

Maybe bitcoinacks could detect a #needs-maintainer-attention or similar tag in comments, and detect maintainer responses. This way people could flag PRs that seem ready for merging or need other input, and maintainers could see the PRs that need actually need their attention, while giving other PRs less priority.
Maybe bitcoinacks could give maintainers a snooze feature, or a way of assigning their own labels or priorities to PRs. For example if @laanwj wants to only consider merging refactoring changes once a month, and not see a list of PRs filled with refactoring changes all the time, maybe bitcoinacks could provide his desired view.

These are just examples, and actual maintainers could probably come up with better suggestions, but it seems to me bitcoin-acks could be pretty useful as a tool for maintainers to keep with PRs, and it might be worth investigating if any new features could help.

First question here for Pierre is just whether you think features targeted at maintainers would be acceptable or make sense as part of bitcoinacks.com. If so, then we could look into what features might be useful.