pilosus/bookland

ISBN barcode generator and scanner

bookland's Issues

Python 3 compatibility

As for v1.4 the app is Python 2 only. Add python 3 compatibility

Refactor to follow PEP8 style guide

Code doesn't follow PEP8. Refactor the code, use static methods when needed, rename class names, fix blank lines issues

No usage information given when app invoked with no options

When the app invoked without obligatory arguments (i.e. productCode), usage information should be printed out:

./bookland
bookland [-h|--help] [-V|--version] [-f|--font=] [-q] [-s|--height=] [-r --reduction=] [-o|outfile=] [-n|--noquietzone] [-a|--autofile] [--cmyk=] [--rgb=] productCode [priceCode]
...

Refactor app to a package

As for v1.4 bookland is a command line utility rather than a package one can distribute over PyPI. Refactor the app into a package. Make sure it can be used as a CLI tool as well (shell script?)

Project lacks unit-tests

The project lacks unit-tests. Add unit-tests + nose config.

scan13 seems to be broken

scan13 seems to be broken, at least under OS X::

import Image

Should be changed to:

from PIL import Image

But even then an error occures:

$ python scan13.py /path/to/isbn.eps
IOError: cannot identify image file '/path/to/tmp/folder/

When removing working with temp file, the app still fails. Seems to be a problem with pix = z.load() and pixels.append(pix[i,0]) -- pix is a NoneType. Probably, Image.getpixel(xy) should be used instead.

Misleading output when -o option used

When invoked with -o|output_file_name option, app indeed writes an ISBN to the specified file, but prints to stdout a filename as if the app was invoked with -a option:

./bookland -o test.eps -f OCRB 978-0-9879594-4-7
This is free software and comes with NO WARRANTY
wrote ISBN9780987959447.eps

Should be:

./bookland -o test.eps -f OCRB 978-0-9879594-4-7
This is free software and comes with NO WARRANTY
wrote test.eps