Giter Site home page Giter Site logo

Comments (6)

piroor avatar piroor commented on May 27, 2024

In short: Choosing the option will apply the BG color same to Windows: TST Options => "Development" => "Color scheme" => "Photon".

The color choice is intentional. There are various desktop themes on Linux distributions, and it is major on Linux community to change color scheme of the desktop environment - there is no "standard", so "Photon" color scheme may become unnatural on some environments easily. So I decided preferring system color on Linux. The BG color referes "ThreeDShadow" on the system color, it is "darkgray" on the "Photon" color scheme. It will become more darker color if you configure color definitions of your desktop environment system more darker. Or a user style sheet (under TST Options => Advanced) to override the color is also available, like:

:root { --tabbar-bg: darkgray; }

from treestyletab.

bughit avatar bughit commented on May 27, 2024

it is major on Linux community to change color scheme of the desktop environment

I'm fairly sure that Firefox chrome (whatever is under its control, within the window chrome which may be os specific) is intended to be the same (or as close as possible) across OSes.

image

This intent is pretty clear from the above win/linux comparison. You are violating this convention by choosing to style parts of TST differently on linux. Your different background sticks out as an unwelcome exception to this rule. By default there should not be a difference. If you believe anyone actually wants this, which is doubtful, it should be optional.

from treestyletab.

bughit avatar bughit commented on May 27, 2024

There is somewhat of a general color difference between linux and win, but I'm referring more to preserving the contrast difference between the foreground and the background, than the exact color values.

from treestyletab.

piroor avatar piroor commented on May 27, 2024

I'm fairly sure that Firefox chrome (whatever is under its control, within the window chrome which may be os specific) is intended to be the same (or as close as possible) across OSes.

Here is an anti-example: Firefox 124 on ArchLinux with the "Adapta" theme.
image
The dark background color of the tab bar is referred with the special system color name -moz-headerbar (or -moz-headerbarinactive, both special colors cannot be used from addon's resources) so Firefox just uses the color defined in the GNOME theme. As the result the contrast around tab face and tab background is quite different from Windows.

from treestyletab.

piroor avatar piroor commented on May 27, 2024

I think we cannot choose colors providing same contrast on all platforms, so I chose second-best: system colors which are expected to have enough contrast.

Anyway I agree that "ThreeDShadow" the current choice is little pale on this case so there is any other possible choice. I'm not negative to change the color I use for the background, but the new choice need to have contrast enough on various environments (e.g. ArchLinux + Adapta).

from treestyletab.

github-actions avatar github-actions commented on May 27, 2024

This issue has been closed due to no response within 7 days after labeled as "wontfix", 7 days after last reopened, and 7 days after last commented.

from treestyletab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.