Giter Site home page Giter Site logo

Comments (10)

piroor avatar piroor commented on June 24, 2024 2

System colors are defined at https://www.w3.org/TR/css-color-4/#typedef-system-color but please note that chose colors may be rendered differently on other environments, for example "ButtonFace" will be a light gray and "ButtonText" will be black on environments with "Light" color scheme but "ButtonFace" will be dark gray and "ButtonText" will be white on environments with "Dark" color scheme. We addon developer need to choose better combination which is effective on various environments as possible as we can.

from treestyletab.

sgjohnson1981 avatar sgjohnson1981 commented on June 24, 2024

Note: this is the High Contrast theme.

from treestyletab.

piroor avatar piroor commented on June 24, 2024

Hmm, could you try setting a user style sheet as following?:

:root {
  --tab-border: GrayText;
}

Basically the "High Contrast" theme aims to provide enough contrast for handicappers about their visibility, so it prefers visibility than elegantism. In previous version the border color is defined as "ButtonShadow" but it is now same to "ButtonFace" which is used for tab faces, on recent version Firefox (I don't know it is an intentional change or a unintentional bug). "ButtonBorder" also looks too thin, so I chose "ButtonText" for the border color - which definitely have enough contrast.

But I agree that too high contrast is also not a best choice. I think that "GrayText" - it is for text color of disabled UIs - should be between "ButtonText" and "ButtonFace" and the better choice for this case. How do you think?

from treestyletab.

sgjohnson1981 avatar sgjohnson1981 commented on June 24, 2024

I have no idea what you're referring to. GrayText is similar enough to what it was. I tried playing around with the instructions for inspecting the add-on but I couldn't figure it out.

from treestyletab.

piroor avatar piroor commented on June 24, 2024

Sorry for less description. Here is detailed instructions:

  1. Start Firefox.
  2. Install TST.
  3. Go to TST Options.
  4. Appearance => Choose "High Contrast"
  5. Advanced => User Style Sheet => add a style declaration :root { --tab-border: GrayText; }

from treestyletab.

sgjohnson1981 avatar sgjohnson1981 commented on June 24, 2024

Sorry, I wasn't clear either. I meant the second part about the different property tags. If you just enter "GrayText" I don't understand what all the other things have to do with it. Though I am curious what other colors are available.

When I said "GrayText is similar enough" I meant I was able to change it with the CSS you included and it seems similar enough to what was in 4.0.11.

from treestyletab.

SteveFromAccounting avatar SteveFromAccounting commented on June 24, 2024

This worked, thanks! This changed with the recent update in both macOS Ventura as well as Windows, but changing it back to GrayText using the HighContrast theme still made it look black for me, so I just set it to rgb(210, 210, 214) manually for myself.

from treestyletab.

ssergiienko avatar ssergiienko commented on June 24, 2024

jFYI for someone who it might be useful. I got best results with --tab-border: ButtonBorder; which is good both in regular mode and at dark incognito.

from treestyletab.

github-actions avatar github-actions commented on June 24, 2024

This issue has been labeled as "stale" due to no response by the reporter within 1 month (and 7 days after last commented by someone). And it will be closed automatically 14 days later if not responded.

from treestyletab.

github-actions avatar github-actions commented on June 24, 2024

This issue has been closed due to no response within 14 days after labeled as "stale", 7 days after last reopened, and 7 days after last commented.

from treestyletab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.