pistolero/zbxsend

Python module for sending metrics to Zabbix

zbxsend's Issues

Support for Python 3

Hello,

The script does not support Python 3.
Are you actively working on it or it has been abandoned?

I have a few changes if you are interested

Return value is True even if value is not actually sent

Hey,

The function for sending data only evaluates if the response from the Zabbix server was valid or not:

if resp.get('response') != 'success':

There are cases where the response is successful though actually sending the value failed:

[Dbg]>>> print resp.get('info')
processed: 0; failed: 1; total: 1; seconds spent: 0.000022
[Dbg]>>> print resp.get('response')
success

Maybe you could add another condition for the evaluation, something as simple as:

if resp.get('response') != 'success' or resp.get('info').find('failed: 1') != -1:

Thanks

zbxsend.py sends a non-integer timestamp

There is a bug in how the clock element of JSON is formed:

for m in metrics:
    clock = m.clock or time.time()
    metrics_data.append(('\t\t{\n'
                         '\t\t\t"host":%s,\n'
                         '\t\t\t"key":%s,\n'
                         '\t\t\t"value":%s,\n'
                         '\t\t\t"clock":%s}') % (j(m.host), j(m.key), j(m.value), clock))

If a timestamp is not provided with the metric, it uses time.time(), which returns a floating-point value and that floating-point value is then inserted into the JSON. However, according to the protocol, Zabbix expects to have an integer Unix timestamp there.

Please see https://support.zabbix.com/browse/ZBX-10234 for more information.