pkainulainen/maven-examples

maven-examples's Issues

Renaming artifact and final file

Thank you for the blog post and the code. I have a small suggestion. The current final name of maven-assembly-plugin and artifactId of assembly-plugin sound too much like the actual plugin used maven-assembly-plugin. If you rename your own artifact and final name to something like say "MyProject", it will be easier to understand things.

Example of Jacoco report ?!

Hi,

i am sorry to open a Issues, so I don't find anything to comment ...

Do you have some result for your example of code-coverage-jacoco ... ?!
when I run this and try to show in sonar ... I use : "mvn clean verify -P all-tests sonar:sonar"
or "mvn clean verify -P all-tests jacoco:prepare-agent jacoco:report sonar:sonar"

Do you try this with SonarQube ?!

Regards,
Mortagne

Have ITFizzBuzzTest test a Jersey endpoint and show lines executed

http://www.petrikainulainen.net/programming/maven/creating-code-coverage-reports-for-unit-and-integration-tests-with-the-jacoco-maven-plugin/ looks great and the examples at https://github.com/pkainulainen/maven-examples/blob/master/code-coverage-jacoco/README work fine but https://github.com/pkainulainen/maven-examples/blob/master/code-coverage-jacoco/src/integration-test/java/ITFizzBuzzTest.java doesn't seem like an integration test to me. It instantiates FizzBuzz and calls a method on it. To me an integration test hits a REST API endpoint.

What if ITFizzBuzzTest called into a Jersey API endpoint with https://github.com/jayway/rest-assured ? (See https://github.com/IQSS/dataverse/blob/v4.2.1/src/test/java/edu/harvard/iq/dataverse/api/BuiltinUsersIT.java#L62 for an example). Would Jacoco know which lines of code were executed? If so, that would be fantastic!

I sort of have my doubts, though, since at http://stackoverflow.com/questions/17433046/integration-test-of-rest-apis-with-code-coverage/17436389#17436389 I'm reading that like me they haven't figured out how to get Jacoco to show code coverage from rest-assured tests. Maybe @johanhaleby or @marchof or @theon knows. I hope this makes sense!