pkp/crossref-ojs

A Crossref plugin for OJS.

crossref-ojs's Issues

Title string from Native XML import not recognized by Crossref plugin

Hello! I just imported an issue to our OJS instance using the Native XML plugin. However, automatic registration of DOIs with the Crossref plugin failed. Manual deposit through the plugin also failed. This is the error text: "Deposit contains title error(s): Title name value is missing from the title element"

I exported the Crossref XML for review, and the <title> tag is empty. This seems like it may be a bug, since the title is present in the imported XML, and also in OJS.

It looks similar to this bug, but I'm uploading articles from the same journal:https://forum.pkp.sfu.ca/t/crossref-submission-fails-because-plugin-expects-parameter-1-to-be-string-array-given-ojs-3-3-0-7/71366/2

I'm using this PHP program to generate my OJS Native XML:
https://github.com/ualbertalib/ojsxml

If it's not a bug, how should I fix the issue? Sorry if this is the wrong place to ask. Thanks for your help

Change the timestamp

I wish you can update the timestamp in filter/IssueCrossrefXmlFilter.inc.php
If I deposit directly to Crossref the format of the timestamp is consistent of 17 numbers according to this format:
YYYYMMDDHHMMssvvv
Can you please change it in OJS so that it is consistent?

Hence change
time()
to
date("YmdHisv")
in the code at the two rows:

crossref-ojs/filter/IssueCrossrefXmlFilter.inc.php

Lines 102 to 103 in 64cb750

	$headNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'doi_batch_id', htmlspecialchars($context->getData('initials', $context->getPrimaryLocale()) . '_' . time(), ENT_COMPAT, 'UTF-8')));
	$headNode->appendChild($node = $doc->createElementNS($deployment->getNamespace(), 'timestamp', time()));

Incorrect exception used in deposit catch block

The exception type-hinted in the catch block does not correspond to the exception thrown, so the catch block is bypassed. This ignores the DOI-related actions in the catch block and causes the job to be registered as a failure.

crossref-ojs/CrossRefExportPlugin.php

Line 302 in 7a6f4d5

} catch (GuzzleHttp\Exception\RequestException $e) {

It should use GuzzleHttp\Exception\GuzzleException instead.

Possibly incorrect string concatenation for XML name

Dear pkp-Team,
we were trying to deposit a large number of articles (ca. 100). However, the deposit action was resulting in errors. According to the error logs, the error message said that the file name was getting too long. After debugging I've noticed that the filename part is basically being reused with every iteration of the for-loop:

$objectsFileNamePart = $objectsFileNamePart . '-' . $object->getId();

Compared to the datacite plugin (where the variable is named $objectFileNamePart):

$objectFileNamePart = $objectsFileNamePart . '-' . $object->getId();

Not sure if this is only an issue with our installation or if I am missing something...

OJS Version: 3.3.0.3
crossref-Plugin version: 2.1.0.0

Best,
Tina

Display index page for Tools > Import/Export > Crossref XML Export Plugin

Describe the Bug:
When going to Tools > Import/Export > Crossref XML Export Plugin an exception is thrown. Instead display the index.tpl page with further information, where to find the new settings and export possibilities.

Using OJS 3.4

PRs:

• #33
• pkp/ojs#3880 (only submodule update)

Display status of issue DOIs?

Hello,

We have both issue and article DOIs enabled in the plugin settings, but only an "Articles" tab appears in the plugin interface, the listings of which don't seem to include the full issue DOI. The plugin appears to have registered the issue DOI just fine, and it is resolving without any problem, I am just surprised not to see its status listed in the interface, nor does it seem like one could manually validate or manually deposit the issue DOI as a consequence.

Just making sure this is working as designed. Thanks!

Failing registration with missing metadata in multilanguage journal

Dear @bozana and @asmecher ,

we just had the situation that the plugin attempted to register an article in a multi-language journal (German & English). The editor entered the metadata for the article's author only in the German form, while leaving the English metadata blank. In the DOI registration process however, the plugin stopped working (and did not process the subsequent articles) when hitting the described article.

Can you reproduce the bug?

Thanks in advance.

Best Regards,

Adrian

Way to set language for articles in OJS Export

Hello, as I have checked from the XML file exported from the plugin, the language is set only per tag, not per <journal_article> tag. Is there a way to set the article languages in the settings, so that the CrossRef XML Export Plugin
exports also the language of the article to Crossref, and to their partners through them.