pkp/defaulttranslation

This plugin displays English translation if the current UI language translation doesn't exist.

defaulttranslation's Issues

en_ES should be es_ES

URL: https://github.com/pkp/defaultTranslation/tree/ojs-dev-2_4/locale/en_ES

Add tests

Describe the problem you would like to solve
Tests are needed in order to detect malfunctions before releasing new packages and to increase the developers confidence when updating code.

Describe the solution you'd like
Follow the current test pattern for plugins (e.g. https://github.com/pkp/customLocale/blob/main/.travis.yml).

Who is asking for this feature?
Developer

English locale in Manuscript theme instead of missing Kyrgyz

Hi, I am trying to display an English locale in manuscript theme where Kyrgyz language is missing, but it looks like this:

What could be wrong?

OJS 3.4.0.4
Plugin version 1.2.0.0

Update the plugin to work with the next release (3.4.0)

At this moment the plugin is using a non-existent hook and depending on code that doesn't exist anymore.
It must be updated to work with the current code at the /main branch of OJS/OPS/OMP.

PR:

• #10

Error 500 in OPS 3.4

Hello! I'm working on a OPS 3.4.0.4. I installed and activated the defaultTranslation Plugin.
->
After this I went to submissions -> (Chose a submission) View ->Preprint-> Permissions & Disclosures. After that I switched the language to spanish.

After this I got error 500 on the page. And when looking at the log I found this:

[13-Mar-2024 10:17:09 America/Argentina/Cordoba] PHP Fatal error: Uncaught TypeError: ucfirst(): Argument #1 ($string) must be of type string, null given in /home/paideias/preprints.latarxiv.org/lib/pkp/classes/i18n/LocaleMetadata.php:190
Stack trace:
#0 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/i18n/LocaleMetadata.php(190): ucfirst()
#1 /home/paideias/preprints.latarxiv.org/plugins/generic/defaultTranslation/DefaultTranslationPlugin.php(123): PKP\i18n\LocaleMetadata->getScript()
#2 [internal function]: APP\plugins\generic\defaultTranslation\DefaultTranslationPlugin->APP\plugins\generic\defaultTranslation{closure}()
#3 /home/paideias/preprints.latarxiv.org/plugins/generic/defaultTranslation/DefaultTranslationPlugin.php(126): uasort()
#4 /home/paideias/preprints.latarxiv.org/plugins/generic/defaultTranslation/DefaultTranslationPlugin.php(89): APP\plugins\generic\defaultTranslation\DefaultTranslationPlugin->getSuitableLocales()
#5 /home/paideias/preprints.latarxiv.org/plugins/generic/defaultTranslation/DefaultTranslationPlugin.php(54): APP\plugins\generic\defaultTranslation\DefaultTranslationPlugin->translate()
#6 [internal function]: APP\plugins\generic\defaultTranslation\DefaultTranslationPlugin->APP\plugins\generic\defaultTranslation{closure}()
#7 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/Hook.php(139): call_user_func_array()
#8 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/Hook.php(113): PKP\plugins\Hook::run()
#9 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/i18n/Locale.php(421): PKP\plugins\Hook::call()
#10 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/i18n/Locale.php(104): PKP\i18n\Locale->translate()
#11 /home/paideias/preprints.latarxiv.org/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php(938): PKP\i18n\Locale->get()
#12 /home/paideias/preprints.latarxiv.org/lib/pkp/lib/vendor/laravel/framework/src/Illuminate/Foundation/helpers.php(973): trans()
#13 /home/paideias/preprints.latarxiv.org/plugins/themes/default/DefaultThemePlugin.php(110): __()
#14 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/ThemePlugin.php(130): APP\plugins\themes\default\DefaultThemePlugin->init()
#15 [internal function]: PKP\plugins\ThemePlugin->themeRegistered()
#16 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/Hook.php(139): call_user_func_array()
#17 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/Hook.php(113): PKP\plugins\Hook::run()
#18 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/plugins/PluginRegistry.php(128): PKP\plugins\Hook::call()
#19 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/components/forms/context/PKPThemeForm.php(66): PKP\plugins\PluginRegistry::loadCategory()
#20 /home/paideias/preprints.latarxiv.org/lib/pkp/pages/management/ManagementHandler.php(204): PKP\components\forms\context\PKPThemeForm->__construct()
#21 /home/paideias/preprints.latarxiv.org/lib/pkp/pages/management/ManagementHandler.php(93): PKP\pages\management\ManagementHandler->website()
#22 [internal function]: PKP\pages\management\ManagementHandler->settings()
#23 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/core/PKPRouter.php(334): call_user_func()
#24 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/core/PKPPageRouter.php(277): PKP\core\PKPRouter->_authorizeInitializeAndCallRequest()
#25 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/core/Dispatcher.php(165): PKP\core\PKPPageRouter->route()
#26 /home/paideias/preprints.latarxiv.org/lib/pkp/classes/core/PKPApplication.php(388): PKP\core\Dispatcher->dispatch()
#27 /home/paideias/preprints.latarxiv.org/index.php(21): PKP\core\PKPApplication->execute()
#28 {main}
thrown in /home/paideias/preprints.latarxiv.org/lib/pkp/classes/i18n/LocaleMetadata.php on line 190
[13-Mar-2024 10:34:56 America/Argentina/Cordoba] ops: 404 Not Found