Proto2 Support

[planetscale]

Proto2 Support

[vmg]

Nope, this is expected (and I unfortunately forgot to document it 😓). I intentionally skipped support for proto2 because Vitess doesn't use it and it makes memory pooling trickier. I take it your project is stuck in proto2 and not planning to upgrade to proto3? I'm still unsure of whether the additional complexity of supporting legacy proto2 is worth it, given the minimal use case.

[gmather]

The specific case is some legacy proto2 messages getting referenced in proto3 messages which causes compile errors as the vtproto helpers are not generated but are expected to exist in the proto3 helpers. This isn't a blocker, I just wanted to confirm since I didn't see it specifically documented.

[euroelessar]

As an additional entry point - our codebase does still have hundreds of proto2 files and the migration would be tricky and often risky.

This makes me interested if you're willing to accept patches to support generation (un)marshal/size methods for proto2?

I understand that pooling logic is tricky and we could skip it & ask people to migrate to proto3 for this additional feature.

[vmg]

@euroelessar: sure thing. It actually shouldn't be a massive change, some of the generators already have a proto3 param that toggles between proto2 and proto3 generated code. It's just a matter of finishing up all the corner cases. If you send a PR I'll review it.