Logger should use Application's classloader, not this.getClass()

[playframework]

Logger should use Application's classloader, not this.getClass()

[galderz]

This is on Play 2.1.0.

[galderz]

A workaround for situations where the Play libraries and the web application reside in different classloaders is to use -Dlogger.file= system property, but this is less than ideal.

[huntc]

Thanks for the comment. Are you referring to incorrect documentation on our part or an issue within our code?

[galderz]

Code of course:
https://github.com/playframework/Play20/blob/master/framework/src/play/src/main/scala/play/api/Logger.scala#L24

Application trait comes with a potential custom classloader as parameter, if present, that application classloader should be used for anything the Play server needs to do where it needs a classloader, i.e. loading a class, loading a resource...etc.

[jroper]

This is not as simple as it sounds, since in dev mode (where using the right classloader matters), the logger is used and initialised before the application or its classloader even exists. Then, on each reload, the logger is reinitialised, but I think this is during the initialisation of the application, which means its not safe to use the application at that point to access the classloader. We'll need to look carefully at the init code in Play. Possibly we should be passing a classloader to the init and then configure methods, and hopefully the place from which we call those has access to the right classloader to use.

[jroper]

Fixed in #1448.