plbrault/weasleyjs

A simple dependency registry for JavaScript

weasleyjs's Issues

Extending lazy-loaded class does not work properly

This test fails on v0.2.0-beta.3:

  it('should be possible to extend a lazy-loaded class', function () {
    const BaseClass = lazyLoad(require.resolve('./testModules/sampleClassModule'));
    class Cls extends BaseClass() {
      constructor(...args) {
        super(...args);
      }
    }
    const inst = new Cls('Nitwit', 'Blubber', 'Oddment', 'Tweak');
    expect(inst.albusQuote).to.be.equal(sampleDependency.speak());
    expect(inst.constructorArgs[0]).to.be.equal('Nitwit');
    expect(inst.constructorArgs[1]).to.be.equal('Blubber');
    expect(inst.constructorArgs[2]).to.be.equal('Oddment');
    expect(inst.constructorArgs[3]).to.be.equal('Tweak');
  });

ReferenceError: Can't find variable: Proxy

Cause:

Some JavaScript engines do not support ES6 proxies, and according to Babel documentation, they cannot be transpiled or polyfilled.

http://stackoverflow.com/questions/35025204/javascript-proxy-support-in-babel

`Cannot call a class as a function` when using a class dependency as base class

To reproduce:

const myBaseClass = weasley.container.myBaseClass.new;

class MySubclass extends MyBaseClass {
  constructor() {
    super();
  }
}

The same error happens if I don't use .new when importing.

Dependency is undefined

Problem

When registering dependencies with the same path, the ones declared before are overwritten to undefined.

To reproduce

// weasly.js
import Weasley from 'weasley';

const weasley = new Weasley();
export default weasley;

weasley.register('lib.Logger', () => require('./Logger'));
weasley.register('lib.Settings', () => require('./Settings'));

// Usage
import weasley from './weasley';

const Logger = weasley.container.lib.Logger;
Logger.getLogger(this.constructor.name); // Error cannot call `getLogger` of `undefined`