Issue with picking up noqa issues after other comment

[plinss]

Issue with picking up noqa issues after other comment

[jonyscathe]

Sorry, I thought this was simpler than it is....
In some simple test cases I don't get the issue - will try come up with a minimal reproduction of some sort.

[plinss]

I'm not able to reproduce this, can you post some sample code?

Also, please post the output of flake8 --version

[jonyscathe]

Oh I am an idiot

flake8-bandit was causing a crash due to a compatibility issue with bandit which was causing errors to not show up! So nothing at all to do with flake8-bandit...

I found this "issue" while trying to track down why NQA102 wasn't coming up in some code where I knew the issue behind the original violation had been solved.

The issue we are actually having is that if we have some line with both a mypy error and a flake8 error we have to have both a type ignore and a noqa:

from pandas.core.frame import DataFrame
from pandas.core.series import Series

def load_data() -> tuple[Series, DataFrame, DataFrame]:  # type: ignore[type-arg] # noqa: FNE004

That all works fine. Then if we change the function name so that FNE004 isn't an issue anymore:

from pandas.core.frame import DataFrame
from pandas.core.series import Series

def load_data_from_file() -> tuple[Series, DataFrame, DataFrame]:  # type: ignore[type-arg] # noqa: FNE004

Then we do not get any NQA102 errors.

So basically:

def load_data() -> tuple[Series, DataFrame, DataFrame]:  # type: ignore[type-arg] # noqa: FNE004

gives no errors correctly

def load_data_from_file() -> tuple[Series, DataFrame, DataFrame]:  # type: ignore[type-arg] # noqa: FNE004

gives no errors, but should give NQA102

def load_data_from_file() -> tuple[Series, DataFrame, DataFrame]:  # type: ignore[type-arg]

Raises a FNE004

def load_data_from_file() -> tuple[Series, DataFrame, DataFrame]:  # noqa: FNE004

Raises an NQA102 (and a mypy error)

I think it is just an issue where flake8-noqa doesn't recognise the noqa comment if it is after any other comment.
And the only possible way to suppress a mypy and flake8 error on the same line is to use the style # type: ignore[code] # noqa: code