Issue with noqa comment & commented out code w/ flake8-eradicate

[plinss]

Issue with noqa comment & commented out code w/ flake8-eradicate

[shestakovks]

Thank you for your time!

[plinss]

The problem here is in flake8-eradicate, when it sees the noqa in the comment then it stops emitting the ‘E800’ error, so flake8-noqa really does not see any matching violations.

flake8-eradicate needs to return the error regardless of the noqa in the comment and simply let flake8’s noqa mechanism suppress the error. (Respecting the noqa is an anti-pattern that no plugin should do.)

Furthermore, looking at the underlying eradicate module that flake8-eradicate is using, it doesn’t seem to be properly parsing the noqa comment and ignores the code, e.g. I expect ‘# noqa: X101’ would still suppress the E800 error, when it shouldn’t (another reason to let flake8 handle the noqa.)

[plinss]

BTW, this only started happening recently because I fixed flake8-noqa’s comment parsing. Previous versions didn’t see the noqa when it wasn’t at the beginning of a comment, so it didn’t generate an error for the lack of a violation on the line.