plotx/smart-contracts

Smart contracts for the PlotX protocol

smart-contracts's Issues

Handle 403 page for liquidity and app.plotx.io

Describe the bug
Currently for disallowed geolocations, the website shows 403

To Reproduce
Try accessing via a disallowed geolocation

Expected behavior
Should show a page that IP location is detected from xxx country and the following countries are disallowed.

App.plotx.io not working in metamask browser

Describe the bug
When app is opened within metamask browser, it gets stuck

All filter not working on Leaderboard page

Describe the bug
When directing from another page, the all filter does not work

To Reproduce
Go to Leader board page from market page. No data appears

Show name of currency in participation notification

Describe the bug
The notification does not state which market received a prediction.

Expected behavior
The notification should mention new prediction on ETH/USD or BTC/USD

Screenshots

Button for raising dispute doesn’t work on mobile[Short description of bug]

The 08:00 bitcoin market needs disputing, clearly below $11450 was $11436 on Binance at 20:00 surely not that much difference.

What was the chain link price?
Button for raising dispute doesn’t work on mobile

It clearly takes the actual settlement price early. Come on guys if we can’t get this right what hope have we got. Everybody will be disputing results. This is fundamental and wrong needs fixing as a matter of urgent

Create adapter for DefiPulse

Is your feature request related to a problem? Please describe.
PlotX to be listed on defiPulse

Describe the solution you'd like
Create adapter for DeFi pulse to show the TVL locked

Create page with date as input and generate report button

Create a web page for generating "challenge " script result by entering date

Negative pending amount and wrong return amount in the 'MY ACCOUNT' page

Address - 0xc8555668862f2c9c0123d7a65513e8b9a86f4159

Display in UI when Market Settlement is under Mining.

When a market settlement is under mining , it should be shown in the UI that settlement is in process for that particular market.

Transaction confirmed on Etherscan, but not showing in My Account or Leaderboard

Transaction confirmed on Etherscan, but doesn't shows up in "My Account" or "Leaderboard"
User predicted on 2 different hourly markets and both the transactions were confirmed within 30 seconds in Etherscan, but his address or prediction doesn't shows up on "My Account" or "Leaderboard" neither.

Telegram Username : @KruglovTeam

ETH Address : 0xab4ac4201f412033d2744f235b3e075eacdb0282

Etherscan Transaction Link
Prediction 1 : https://etherscan.io/tx/0xd55c15e5b1c25b70bf5516048958084b3057651bbba69b7059d9176aab8bf151
Prediction 2 : https://etherscan.io/tx/0x5ccbf5fc4d9a8fe61d408e3fd5d5d29fe6cb9cffe039ad64f9f9405a92bef762

Screenshots
2 screenshots attached

Prediction 1 :

Prediction 2 :

Leaderboard numbers are showing 0 participation & rewards

Describe the bug
The leaderboard numbers that show market participation data is showing null values

To Reproduce
Steps to reproduce the behavior:

1. Go to the leaderboard page
2. See error

Expected behavior
Amount of the ETH & PLOT staked + Rewards distributed should be updated in real-time

Screenshots

Desktop (please complete the following information):

• Chrome Browser
• Metamask Extension

Disable dispute button in case of 0 participation

Describe the bug
If 0 participants are there, the the dispute functionality does not work. But it looks confusing.

Expected behavior
Disable dispute button in case of 0 participants. Add text
"Please note markets with 0 participants cannot be disputed"

Show only in markets with 0 participants

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Browser [e.g. chrome, safari]
• Extension

Smartphone (please complete the following information):

• Browser [e.g. stock browser, safari]
• Extension

Additional context
Add any other context about the problem here.

Put Uniswap buy links on the "Save 50% fee with predictions in PLOT" text

Save 50% fee with predictions in PLOT should lead to the person buying PLOT

Create APIs for market pages

Is your feature request related to a problem? Please describe.
Data on market page is only being shown when user has signed in via metamask

Describe the solution you'd like
We should be able to show the data using a API, such that a person can see data without signing in via metamask

BTC/USD Market not Settled

The BTC/USD Hourly Market scheduled to be closed at 1:30 PM IST has not settled till now.

Leaderboard Date Selection function not working properly.

Return stakes if n participant

Is your feature request related to a problem? Please describe.
Currently, the 1st participant is not incentivised to participate because there are no pool rewards and he might end up losing money to DAO if he is wrong

Describe the solution you'd like
Return participation amount in case there is only 1 participant, irrespective of whether he is right or wrong.
Dispute should not be allowed if participation = 1

Make the user land on the daily market first and not the hourly market

Hourly markets have less participation than daily ones. Let's ensure the user lands on the daily market for better social proofing.

Create a graph on UI to show Chainlink price movement

Once issue #35 is completed, we can use API to plot a graph with API data.

Error while executing contract transaction

Error while contract execution
I was predicting on What will be the value of ETH/USD at Oct 23 2020 12:30 pm ? (IST). I received this error "Warning! Error encountered during contract execution [Reverted]" while executing the transaction.

ETH Address : 0x7Ba7f68AC3929a2357123440e2DB79d5e6767895

Etherscan : https://etherscan.io/tx/0x73a8dc51fbcf0d51227868e9e806c1e630b4a3afeb8ae845f3e6196464c3aa2b

Screenshots

Create contract for Referral Program

Create a new Referral programme so that users with valid signature can claim bPLOTs

Add popup to give more allowance

Is your feature request related to a problem? Please describe.
Currently, a player needs to approve PLOT every time he/she participates in a market. This results in more gas and tx hindrance

Describe the solution you'd like
Create a link under approve toggle in Live market prediction "Approve more"
Opena popup with text box to enter amount to be approved
Approve button.
Some text should be there around what does approval mean.

Increase decimals precision of LeveragedParticipation in Leaderboadr View

Describe the bug
User had participated with amount of 0.011 with a leverage of 1. So the leveraged amount will be around 0.002, but it is displayed as zero in leaderboard view page.

To Reproduce
Steps to reproduce the behavior:

1. Go to https://app.plotx.io/leaderboard/0xe300faea583e2ef1017b386ce47cb7177cd14cd3

Expected behavior
Leveraged asset should be displayed.

Screenshots

Different txns showing up in Etherscan and Market Leaderboard and My Account page - Venky

ETH Address: 0x4457974926CAe3083004981d03632A21d158B21b

Change name to "Total Rewards Distributed"

Show incentives on Leaderboard View

Is your feature request related to a problem? Please describe.
We have the feature of sponsoring incentives, however, no UI to show that.

Describe the solution you'd like
Show Total Incentives distributed in market i top section
Club Incentives in Rewards in PLOT in the table below

MetaMask Issue

Desc:

Txn Hash:

Screenshot:

helo

Link: Conversation with Orange Shark from Kanpur

Customer: Orange Shark from Kanpur
Customer ID: 828124e7-a7a3-47b8-af5a-7e330b99390d

---

Intercom Operator will send a note to this conversation when this issue is closed.

Incentives for market creation o be calculated based on gas price

Is your feature request related to a problem? Please describe.
Currently, the protocol distributes fixed incentives to users creating markets.

Describe the solution you'd like
Incentives should be based on actual gas price and PLOT price

Participation incentives not showing in the market leaderboard screen

Describe the bug
Total participation incentives are shown as 0 despite multiple participants in the market

To Reproduce
Steps to reproduce the behavior:

1. Go to https://app.plotx.io/leaderboard/0xd9b07d4a863fb7bcb85a113da8703be513d38e36
2. See the Participation incentives field showing 0

Expected behavior
It should be showing 100 PLOT

Screenshots

Show existing transactions that are pending for market creation

Is your feature request related to a problem? Please describe.
It is unclear if market creation transaction has been trigerred by someone else. Henc, more than 1 people trigger transaction and it fails for the 2nd user.

Describe the solution you'd like
Show a table near the Create market button to show the list of transactions that are pending
Asset/Currency Index
MarketType
txHash
Address
Time
Gas price
Gas limit
Status - Pending

Create Referral page to claim bPLOTs

Migrate to Angular 9+

Is your feature request related to a problem? Please describe.
Extensions like walleconnect are not working well. The issue is due to Angulare version adopted

Describe the solution you'd like
Migrate to Angular 9+

User is saying Markets he participated in are not showing

user: Dan3

Txn id:
https://etherscan.io/tx/0x59bd3758eed144295693683507bd4867b14d9e4b98709d9083e3b574afc4f79f
https://etherscan.io/tx/0x8873a1ce550a5ce339233d898b0636bbaae645b8a7d41d948f751779b526bf72

Market Created but haven't received $PLOT for Market Creation

User claims creating a market and didn't receive PLOT as rewards
He doesn't remember which market he created.

Discord Username : @Anit_Jain04#6647

ETH Address :
0xaa09ad51b17948e6f41c8d283de4d7bb25f9becb

Etherscan Tx Address :
https://etherscan.io/tx/0xfec7f4e2fbb068679ec7061c07eff1c4d14aaae5c90e153e1d90be46762fec1f

Liquidity Mining Issue

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Browser [e.g. chrome, safari]
• Extension

Smartphone (please complete the following information):

• Browser [e.g. stock browser, safari]
• Extension

Additional context
Add any other context about the problem here.

Test from Intercom

Hola

Link: Conversation with [email protected]

Customer: [email protected]
Customer ID: 8623c869-1311-4be0-8ee7-0d31d3aded6a

---

Intercom Operator will send a note to this conversation when this issue is closed.

Add Wallet Connect integration to liquidity.plotx.io

Users are unable to connect with MetaMask on mobile with liquidity.plotx.io.

Need Wallet Connect integration like in app.plotx.io.

Create API to Add Chainlink data for 24-hr in leaderboard view

Is your feature request related to a problem? Please describe.
Currently, it is difficult to see the pricefeed by Chainlink and how the result was computed. A graph below the leaderboard table of a market can highlight the price movement on Chainlink

Describe the solution you'd like
Create a listener, to listen to events from Chainlink Aggregator(ETH and BTC)
Then based on market settle time, return all price feeds for +- 12 hours. This info can be used to plot a graph on the UI.

My account page is showing wrong numbers

https://files.slack.com/files-pri/T5UNTH4AF-F01D0LMCV0V/image.png
https://files.slack.com/files-pri/T5UNTH4AF-F01CP1HRFL7/image.png

Add Web3modal to app.plotx

Integrate with https://github.com/Web3Modal/web3modal

Intercom Test. Please ignore :pray

xhbahbxahvx

Link: Conversation with [email protected]

Customer: [email protected]
Customer ID: 46dcfca2-4283-45f6-aeae-365772e3b865

---

Intercom Operator will send a note to this conversation when this issue is closed.

Market with no participation shows "in settlement" when it should be settled.

5:30 Hourly Market with no participation is "In Settlement" when it should be settled by now. (Current time: 5:42)

It shouldn't even be in dispute as there is no participation, although if it needs to go in dispute then it needs to show that.

Reduce decimals in total participation in Leaderboard page

Describe the bug
The numbers in participation are looking too long because of 4 decimals

Expected behavior
Round off the number in PLOT and for ETH, show 2 decimals
Screenshots
If applicable, add screenshots to help explain your problem.

Grammatical Error My Accounts page

There is a grammatical error in the PlotX up under staking. "you will start getting more number of positions for the same about."

It should read "you will start getting a greater number of positions for the same amount."

Wrong amount staked with 300 ETH staked showing up

Show deleveraged amount in the live markets page

We do show reward pool in the in settlement page. I think showing the reward pool directly in live page will be a bit irresponsible but we can show the develeraged amount per option for sure.

Stake multiplier increases without conditions being met

Stake multiplier increases to 1.3 from 1 without the minimum conditions being met.

only 'in-creation' tab is visible on BTC-USD market page.

sometimes only 'in-creation' tab is visible on the BTC-USD market screen, there is no other 'in-settlement' and 'settled' tab visible until user hit the refresh button.

Create analytics page

Is your feature request related to a problem? Please describe.
Difficult to portray specific analytics for PlotX

Describe the solution you'd like
Create UI to show analytics for PlotX
Graphs:
Total Volume Locked
Predictions per day
New users per day
Rewards per day

User had his real 0.1 ETH deducted on the Alpha

"My metamask was on Kovan network. I opened the alpha on the browser and then went on the markets page. Then I switched to the metamask app to see how much kETH I have in my wallet. Then I switched my wallet to the main etherium network to see how much ETH I have on my mainnet account. Then I opened the browser again and clicked on the Predict Now button. Entered 0.1 kETH (but it was 0.1 ETH in reality), and clicked on Buy Now. That took me to my metamask app to ask for payment approval. It got cancelled somehow. Then I went on the browser again, tried it again. Then it took me to my metamask app where I accepted the transaction n transaction was successful."

Address - 0x71439347cae692f66036ba9e9431e33b2563cf7e