Node module against HTTPS

[pocketjoso]

Node module against HTTPS

[pocketjoso]

Had a quick look and it seems like the node module currently does not pass the necessary --ignore-ssl-errors=true --ssl-protocol=tlsv1 flags, in order to support HTTPS.

I'll have a look at this during the weekend, should be very easy to fix!

[JimmyRittenborg]

Or does it, through the config.json ? I might have overlooked that in a rush 😊

[fatso83]

Originally it did this, so in that case be a regression due to some later changes.

@pocketjoso Feel free to assign Node issues to me if you need help.

[pocketjoso]

@fatso83 : Have not yet touched the Node module, so no regression possible there. But just by looking through it, it doesn't seem to be handling neither the config.json file nor these ssl flags for phantomjs - and if so it never did. Or am I missing something?

[pocketjoso]

@JimmyRittenborg I should have mentioned earlier: the module will normally work against https just fine, it's just in the case where there are ssl errors (f.e. expired certificate), or an old ssl version in use that it might not work. In these cased the config.json needs to be used, which I believe the module needs to be updated to handle.

[fatso83]

Don't know about current master, but at least the changes I did in early July, featured in the dev branch includes code that does this.

[fatso83]

I have now made a proper check into the code, and the code is already present in the master, as I meant it was. Not sure where you looked, Jonas, but that wasn't it :-) It has been there since the first Node code was included. It is included as line 9 in the index.js file.

So in essence, this issue should be closed.