Comments (7)
To be fair here, I must ask:
Am I right in thinking this should be done by the Node module
? Or should it be left to the end user to log something in the callback function?
from penthouse.
The node module should not output anything. That does not stop us from doing it in the stand alone version! Once we remove the old behaviour of outputting the result to stdout, and rather output all css to file, stdout will be strictly for user viewable output in the standalone process. We simply refrain from using it in the Node module. The node module uses anything output on stderr, so don't use that for debug output.
from penthouse.
So in essence, you can sprinkle as many console.log
statements you feel like in core.js
, as it won't affect the standalone at all (after we remove the old behaviour, at least)
from penthouse.
Any reason this is open still? Seems resolved to me (as a kind of #wont-fix)
from penthouse.
I still want some progress when the command is run; if you're saying it's a no go for a Node module, then at least for the standalone version.
So would the idea be then to conditionally add log statements when in standalone mode?
from penthouse.
Closing? Ref #41
from penthouse.
Yep.
from penthouse.
Related Issues (20)
- Getting phantomjs error for libfontconfig HOT 2
- Plugin is not considering the js files inclusion HOT 2
- Feature request: support "FULL_HEIGHT" option to allow generation of used CSS HOT 1
- UnhandledPromiseRejectionWarning: Error: Error: Penthouse timed out after 30s. HOT 4
- Cannot read property 'width' of null
- Media queries in the generated .css file see seem inserted in the wrong line numbers HOT 6
- The media query `@media screen and (min-device-width: 20cm) and (min-aspect-ratio: 1/1)` is not inserted in the generated .ccs file. HOT 2
- Error: Failed to launch the browser process! on travis CI HOT 1
- why it crops critical css generated file? HOT 3
- What is CSSstring HOT 5
- Page speed insights CLS time on desktop get increased after resolving render blocking errors HOT 1
- Chrome processes HOT 4
- Output Wrong CSS HOT 1
- not finishing in Docker environment HOT 1
- Puppeteer Update HOT 3
- TypeError: Cannot read property 'clear' of undefined HOT 2
- Navigation timeout infinitely
- bug(iframes): timed out if lazy loaded iframes HOT 2
- Display none elements do not get added to critical
- Puppeteer screenshot works, but not penthouse HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from penthouse.