Giter Site home page Giter Site logo

Comments (6)

DanielOchoa avatar DanielOchoa commented on May 27, 2024

Are you still having this issue? I'm not entirely sure but I think the images should be under the assets dir as well.

from ember-cli-github-pages.

RobbieTheWagner avatar RobbieTheWagner commented on May 27, 2024

Yes, still have the issue. Please look at the page link I posted above. Open the console and you'll see the failed request for the image.

from ember-cli-github-pages.

DanielOchoa avatar DanielOchoa commented on May 27, 2024

The baseURL property that gets set on the index.html only applies to relative url's on the document itself, this means that it will not be set for assets loaded through, say, css.

By inspecting the image relative to other assets I noticed that it is not prefixed by ember-drop like the other assets. For example, the browser is looking for the image under /images when it should be looking for it under /ember-drop/images.

The only thing I can think of now to fix this issue is to change the stylesheet to load the image from /ember-drop/images/cream_pixels.png. This, of course, will break when running the dummy app locally, but you could technically make a gh-pages dist with this path and it should work.

This should solve your problem, although having ember-cli-gh-pages do this for you would be the ideal thing. I'll open an issue on the subject.

from ember-cli-github-pages.

benoror avatar benoror commented on May 27, 2024

I believe that loading img's on runtime will not reference the asset correctly, I'm having a similar issue: #45

Let me know if you solved it 😄

from ember-cli-github-pages.

knownasilya avatar knownasilya commented on May 27, 2024

Like I mentioned in #45, this addon creates a production build, which fingerprints resources automatically. If you have dynamic resources in your templates, they will not be fingerprinted, so you need to ignore the fingerprinting for those resources in your ember-cli-build.js file.

from ember-cli-github-pages.

benoror avatar benoror commented on May 27, 2024

@knownasilya Thanks, here's my solution: #45 (comment)

from ember-cli-github-pages.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.