poetic/ember-cli-github-pages

Easily manage gh-pages of your ember-cli addon

ember-cli-github-pages's Issues

Installation instruction deleted all my work

I just tried following the installation instructions, however it deleted not only my project, but everything in the parent directory.

git checkout --orphan gh-pages && rm -rf `ls -a | grep -vE '\.gitignore|\.git|node_modules|bower_components|(^[.]{1,2}/?$)'` && git add -A && git commit -m "initial gh-pages commit"

I'm shell zsh, so maybe something in here which doesn't work as expected.

Create the gh-pages branch if not existent

if you just try to deploy without creating the branch first it will fail

Command failed: /bin/sh -c git checkout gh-pages
error: pathspec 'gh-pages' did not match any file(s) known to git.

Error: Command failed: /bin/sh -c git checkout gh-pages
error: pathspec 'gh-pages' did not match any file(s) known to git.

    at ChildProcess.exithandler (child_process.js:203:12)
    at emitTwo (events.js:87:13)
    at ChildProcess.emit (events.js:172:7)
    at maybeClose (internal/child_process.js:818:16)
    at Socket.<anonymous> (internal/child_process.js:319:11)
    at emitOne (events.js:77:13)
    at Socket.emit (events.js:169:7)
    at Pipe._onclose (net.js:469:12)

--environment is not a valid option

new to this and when I tried to use --environment=production, I got error saying --environment is not a valid option (--message was the only one listed)

Npm publish v0.0.5

Looks like a release was tagged, but not published to npm

[Enhancement] ember-cli-github-pages should fix asset paths loaded through css/js.

Right now, when making a dist for gh-pages, assets loaded through css or js will not have the correct path, given that gh-pages expects asset paths to have the repo prefix. For example: ember-cli-github-pages/images/some-image.jpg.

Check addon for DemoURL

This would help increase awareness for demo apps, and would help developers looking for addons since emberaddons.com displays a button to the addon's demo.

This would be in case someone is using this addon and doesn't know about package.json['ember-addon']['demoURL'] let them know.

This would add an annoying factor, but it could check for disableDemoURLNotice or something somewhere.

Directly requesting sub routes causes 404

Not sure if there is a good fix for this but I'm seeing this in multiple repos (including my own):
http://matt-jensen.github.io/ember-cli-g-maps/setup/index

and
http://ravellaw.github.io/e3/bubble-1

Should be seeing 404.

Checkbox tick png missing on demo site

If you click on the checkbox the tick does not appear.

https://sauce-consultants.github.io/ember-sauce-material-design/#/forms

Missing quote bug fix for 'hash' is not available in latest tagged version hence npm

I am talking about below commit, which is not available through npm.
c36533a

When installing I get: `ember generate` command requires an entity name to be specified

I just tried to install this on a 0.2.3 cli project

 ember install ember-cli-github-pages

but get this error/output to the console:

The ember generate command requires an entity name to be specified. For more details, use ember help.

Note:I've switched to mac now, not on windows:)

Passing env variable?

Thoughts about having env variable for the build?

Different env var would be used here:
https://github.com/poetic/ember-cli-github-pages/blob/master/lib/commands/commit.js#L25

Use Case:
I have an ember component that uses GitHub pages as a demo. On the GitHub page an extra library is used for syntax highlighting, this isn't needed in production.

I can fork this and make this, just wanted your thoughts. I'm thinking the env variable will default to production.

Custom Domain Configuration Overwritten

When using a custom domain, Github requires a CNAME file. I think this can be done through correct merging of old and new gh-pages branches, but if I understand correctly, ember github-pages:commit will destroy the branch and recreate it, removing any CNAME file that's committed to the branch. Use git push origin gh-pages:gh-pages -f with caution for this reason. Not sure if this is an issue with this add-on, but it's worth noting.

subsequent command fails

After running the command the first time, I wanted to update and run it again, but got this.

ember gh-pages:commit --message "Fix dummy path"
version: 0.1.1
Command failed:
Error: Command failed:
    at ChildProcess.exithandler (child_process.js:637:15)
    at ChildProcess.EventEmitter.emit (events.js:98:17)
    at maybeClose (child_process.js:743:16)
    at Process.ChildProcess._handle.onexit (child_process.js:810:5)

Is it dependent on a different version of ember-cli?

Command failed

Not sure why but I can't deploy again:

Command failed: git -c core.safecrlf=false add "." && git commit -m "Initial gh-pages second"

Error: Command failed: git -c core.safecrlf=false add "." && git commit -m "Initial gh-pages second"

    at ChildProcess.exithandler (child_process.js:271:12)
    at emitTwo (events.js:125:13)
    at ChildProcess.emit (events.js:213:7)
    at maybeClose (internal/child_process.js:927:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:211:5)

rm: "." and ".." may not be removed

At the command:

git checkout --orphan gh-pages && rm -rf `ls -a | grep -vE '.gitignore|.git|node_modules|bower_components|\.\/|\.\.\/'` && git add . && git commit -m "initial gh-pages commit"

I receive this error:

rm: "." and ".." may not be removed

Cannot find images

New issue, that I assume is similar to not being able to find the assets, I now have an issue where it cannot find my images.

http://rwwagner90.github.io/ember-drop/

The image is in the repo, in the gh-pages branch, in an images folder.

What do I need to do to get it to find it?

Command hangs

when I run ember github-pages:commit --message "my commit" I get this singular output, and nothing happens:

version: 2.3.0
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://www.ember-cli.com/user-guide/#watchman for more info.

Do you have any advice for debugging this?

`returnToPreviousCheckout` doesn't work

See lib/commands/commit.js#L51-L55

The command to checkout previous branch doen't work

Not working with ember-cli 0.2.3

Hey,
just wanted to let users know that this plugin is currently not working with ember-cli 0.2.3

I asked if it can be fixed in this repo or ember-cli. See here:
ember-cli/ember-cli#3860

Does this work with the new rootURL?

Seems that Ember CLI has removed baseURL and moved to rootURL. I am now unable to deploy my apps. Please advise.

First-class support for user and organization pages

Github user and organization pages work a little differently than regular repo pages. These repos are identified by having the form

/(?:([\w\-]+)\/(\1).github.io).git$/

The key difference pertaining to this addon is that the branch hosted on github pages is not gh-pages, it's master.

This addon is extremely close to being able to provide first class support for these kinds of repos. I'd like to make the following enhancements:

To provide support for User and Org pages

• To no longer "publish" apps to just gh-pages. Users may specify their branch via #19
• For these repos, the baseURL attribute in config/environment.js should stay as /

To provide excellent support

• Auto-detect whether the repo is one of these special cases, and default to publishing to the master branch instead of defaulting to gh-pages

---

References

• https://help.github.com/articles/user-organization-and-project-pages/

Comaintainers needed

If anyone is interested in helping us maintain this repo, please let me know. We have a small team and way too many open source repos and unfrotuantely many are getting neglected if they don't pertain to a project on which we are actively working.

Please reply and let me know if you'd be intersted in helping out. If you are a freelancer or work for a comapny and help out, we'd be more than happy to accept PR on the README to give yourself credit for helping out with this project.

Thanks!

SHA hash mismatch?

I spun up an ember app today, I want to push it to GH pages, however, in Firefox, it redirects to the same route:

https://allthesignals.github.io/labs-upad-validate/labs-upad-validate/ (<- WHAT?!?!?!)

This was after trying something to address this error:

None of the “sha512” hashes in the integrity attribute match the content of the subresource.

(I reverted but) Why am I seeing errors about sha512 hash? I'm sure this is a really interesting part of web technology but why is Ember build giving me issues here?

In Chrome, it throws a bunch of console errors about broken links to asset files. Yes, I suspect I can address this problem by... what is it? Update rootURL? Add the prepend property to fingerprints in ember-cli-build?

Here's my repo now: https://github.com/allthesignals/labs-upad-validate.

Is there an implicit step that's missing from the README that we should add to avoid this? Sometimes I just want to push up a prototype of something to GH pages, but somehow I end up missing some hidden step. I just cannot see where I am failing to follow the instructions. This is not an org page or a user page (which I assume means the page that appears when you go to the user root page).

Please advise and I will be happy to PR an extra note to the README which I believe followed faithfully, thanks.

Fails if the default bash is FISH

Cannot find assets

My page will not load any of my assets. I saw this issue: ember-cli/ember-cli#398. Does that apply here? If not, why do my assets not load? https://github.com/rwwagner90/ember-shepherd/tree/gh-pages

Adding only dist folder to the gh-pages/master branch

I am using organisation guthub-pages and my website output branch is master. I am keeping the ember specific code in ember branch as specified in the readme.

According to me, executing ember github-pages:commit --message "abc" --branch master command should do the following:

1. Build the ember project.
2. Copy the dist folder from ember branch to master branch.

But contrary to that it is actually copying everything from ember branch to master branch.

Is this the expected behaviour? Or am I missing something?
Is there any way to make it copy only the dist folder to the master branch?

Deploying a second time does not remove previous build's files

When I run github-pages:commit, and there already exists previously-deployed files on the gh-pages branch, they are not removed. Is this a design choice? I expected this to wipe the files and rebuild completely. I've run this a few times and the duplicate files in https://github.com/NathanJang/nathanjang.github.io/tree/9c2d576f0c301fae02bb83fff8613a9690c4ea09/assets is what happens.

Maybe it we just to configure the cp command in more detail, maybe on this line?

ember-cli-github-pages/lib/commands/commit.js

Line 50 in dd4498c

return runCommand('cp -R dist/* .', execOptions);

Thanks!

ember-bootstrap assets not loading

Hi! I am learning Ember and made a User Page which I deployed recently. Unfortunately some of the assets are not loading correctly:

• Page: http://benoror.github.io/
• Repo: https://github.com/benoror/benoror.github.io

I believe the images in the front page are not correctly loaded since they're dynamically created ({{#each...}} statement) on runtime (#10).

What struggles me the most is Bootstrap (CSS/JS), since I installed it using kaliber5.github.io/ember-bootstrap/, as you can see in the console I get the following error:

Failed to find a valid digest in the 'integrity' attribute for resource 'http://benoror.github.io/assets/vendor-e90b85f169eb47329513c2253e3333e2.css' with computed SHA-256 integrity 'sRY8jSb2DsMAa3f+lwjxvBco2xC14NPhem5cOEm20rc='. The resource has been blocked.
http://benoror.github.io/assets/social/email.png Failed to load resource: the server responded with a status of 404 (Not Found)

Any help would be greatly appreciated 😸

Page not found when reload the page

I have just placed an app on github pages and i found a problem with urls:

Github pages seems not to recognize url without "#", if you navigate trought the app clicking on the links it works, but if you refresh the page it shows 404 page, did you have this problem?

Assets not found

Seems like either the urls in index.html need to change. , or the assets moved to an assets/ folder.

Sorry, the assets are one level up, so user.github.io/assets instead of user.github.io/project/assets

Need to change baseURL: '/project-name' in tests/dummy/config/environment.js.

Switch back to previous branch

At the end of the github-pages:commit this addon leaves the git repo on the gh-pages branch.

I think it should switch back to the previous branch, like this command ran completely in the background. 😀

Version 0.2.0 Not Tagged in GitHub

Ditto. Just FYI.

Readme deploy script does not build for production

should be

ember build --environment production && ember github-pages:commit --message \"Deploy gh-pages from commit $(git rev-parse HEAD)\" && git push origin gh-pages:gh-pages

instead

Query params not being picked up

Not sure if this has to do with the way URLs are handled through Location API, but query parameters are not being picked up in the gh-pages deployment....

[Enhancement] Have addon set assetUrl path under config.js for you

In order to have any assets you have in your repo load correctly you need to add the following to your tests/dummy/config/environment.js file:

if (environment === 'production') {
  ENV.baseURL = '/name-of-your-repo'
}

This addon should append this for you, so you do not forget to do it yourself.

Instructions for windows.

If possible can you update the Readme to say what directories to leave in windows as by default rf is not a command.

Ember 2.18 deprecation

I'm getting the following deprecation after upgrading my app to Ember 2.18 and it appears to be coming from this addon:

Esri/ember-cli-cedar@60f340d

It seems related to ember-cli/ember-cli-version-checker#48 (comment)

It looks like you've already upgraded ember-cli-dependency-checker (it's in both depenencies and devDependencies actually), but just haven't done a release yet.

I did a quick test by updating my package.json to point to master w/ "ember-cli-github-pages": "poetic/ember-cli-github-pages"and re-installed, and I no longer see the deprecation,so I think that if you are able to just release master as is that would fix this issue.

Radio button not working on demo site

No radio button appearing.

https://sauce-consultants.github.io/ember-sauce-material-design/#/forms