Giter Site home page Giter Site logo

pokemon-tcg-data's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

pokemon-tcg-data's Issues

Typo of Farfetch'd in Base.json

Missing 't'
Farfech'd -> Farfetch'd

"text": "Flip a coin. If tails, this attack does nothing. Either way, use this attack again as long as Farfetch'd stays in play (even putting Farfech'd on the Bench won't let you use it again.)"

Missing json

I can't find the file for:
https://api.pokemontcg.io/v1/cards/ex3-98 - Charmander 98/97
https://api.pokemontcg.io/v1/cards/ex3-99 - Charmeleon 99/97
https://api.pokemontcg.io/v1/cards/ex3-100 - Charizard 100/97
https://api.pokemontcg.io/v1/cards/ex4-96 - Absol 96/95
https://api.pokemontcg.io/v1/cards/ex4-97 - Jirachi 97/95
https://api.pokemontcg.io/v1/cards/ex5-102 - Groudon 102/101
https://api.pokemontcg.io/v1/cards/ex6-113 - Charmander 113/112
https://api.pokemontcg.io/v1/cards/ex6-114 - Articuno ex 114/112
https://api.pokemontcg.io/v1/cards/ex6-115 - Moltres ex 115/112
https://api.pokemontcg.io/v1/cards/ex6-116 - Zapdos ex 116/112
https://api.pokemontcg.io/v1/cards/ex7-110 - Charmeleon 110/109
https://api.pokemontcg.io/v1/cards/ex7-111 - Here Comes Team Rocket! 111/109
https://api.pokemontcg.io/v1/cards/ex8-108 - Raikou ex 108/107
https://api.pokemontcg.io/v1/cards/ex9-107 - Farfetch'd 107/106
https://api.pokemontcg.io/v1/cards/bw1-115 - Pikachu 115/114
https://api.pokemontcg.io/v1/cards/bw4-101 - Chandelure 101/99
https://api.pokemontcg.io/v1/cards/bw4-102 - Zoroark 102/99
https://api.pokemontcg.io/v1/cards/bw4-103 - Hydreigon 103/99
https://api.pokemontcg.io/v1/cards/dv1-21 - Kyurem 21/20
https://api.pokemontcg.io/v1/cards/xyp-XY162 - Greninja XY162
https://api.pokemontcg.io/v1/cards/xyp-XY163 - Weezing XY163
https://api.pokemontcg.io/v1/cards/xyp-XY166 - M Gengar EX XY166
https://api.pokemontcg.io/v1/cards/xyp-XY179 - Snorlax XY179
https://api.pokemontcg.io/v1/cards/xyp-XY180 - Arcanine BREAK XY180
https://api.pokemontcg.io/v1/cards/xyp-XY182 - Mandibuzz BREAK XY182
https://api.pokemontcg.io/v1/cards/xy4-120 - M Manectric EX 120/119
https://api.pokemontcg.io/v1/cards/xy4-121 - M Gengar EX 121/119
https://api.pokemontcg.io/v1/cards/xy4-122 - Dialga EX 122/119
https://api.pokemontcg.io/v1/cards/xy5-161 - Dive Ball 161/160
https://api.pokemontcg.io/v1/cards/xy5-162 - Enhanced Hammer 162/160
https://api.pokemontcg.io/v1/cards/xy5-163 - Switch 163/160
https://api.pokemontcg.io/v1/cards/xy5-164 - Weakness Policy 164/160
https://api.pokemontcg.io/v1/cards/xy12-110 - Flying Pikachu 110/108
https://api.pokemontcg.io/v1/cards/xy12-111 - Surfing Pikachu 111/108
https://api.pokemontcg.io/v1/cards/xy12-112 - Imakuni?'s Doduo 112/108
https://api.pokemontcg.io/v1/cards/xy12-113 - Here Comes Team Rocket 113/108
https://api.pokemontcg.io/v1/cards/smp-SM103 - Lunala-GX SM103
https://api.pokemontcg.io/v1/cards/smp-SM104 - Solgaleo-GX SM104
https://api.pokemontcg.io/v1/cards/sm6-143 - Energy Recycler 143/131

Check either if the "imageUrlHiRes" exists!

Ultra Prism does not exist yet

This isn't an issue to stir anything up , but merely to start the conversation around helping maintain the data.

I would like to start using this data in an application, and want to make sure I can help maintain the data set.

Are you generating the data off of another site? Or is it all manual data entry?

No category for Held Items

The Held Items that were in the game during the DPP era don't have their own category but are "bare" in the data. Would it be possible to have a category for them?

For example, compare the following cards:
{ "id": "dp2-2", "name": "Alakazam", "imageUrl": "https://images.pokemontcg.io/dp2/2.png", "subtype": "Stage 2", "supertype": "Pokémon", "level": "47", "evolvesFrom": "Kadabra", "ability": { "name": "Power Cancel", "text": "Once during your opponent's turn, when your opponent's Pokémon uses any Poké-Power, you may discard 2 cards from your hand and prevent all effects of that Poké-Power. (This counts as that Pokémon using its Poké-Power.) This power can't be used if Alakazam is affected by a Special Condition.", "type": "Poké-Power" }, "hp": "100", "retreatCost": [ "Colorless" ], "convertedRetreatCost": 1, "number": "2", "artist": "Kouki Saitou", "rarity": "Rare Holo", "series": "Diamond & Pearl", "set": "Mysterious Treasures", "setCode": "dp2", "types": [ "Psychic" ], "attacks": [ { "name": "Psychic Guard", "cost": [ "Psychic", "Psychic", "Colorless" ], "convertedEnergyCost": 3, "damage": "50", "text": "During your opponent's next turn, any damage done to Alakazam by attacks from your opponent's Stage 2 Evolved Pokémon is reduced by 30 (after applying Weakness and Resistance)." } ], "weaknesses": [ { "type": "Psychic", "value": "+30" } ], "imageUrlHiRes": "https://images.pokemontcg.io/dp2/2_hires.png", "nationalPokedexNumber": 65 },

{ "id": "dp2-73", "name": "Bidoof", "imageUrl": "https://images.pokemontcg.io/dp2/73.png", "subtype": "Basic", "supertype": "Pokémon", "level": "11", "hp": "60", "retreatCost": [ "Colorless", "Colorless" ], "convertedRetreatCost": 2, "number": "73", "artist": "Yusuke Ohmura", "rarity": "Common", "series": "Diamond & Pearl", "set": "Mysterious Treasures", "setCode": "dp2", "text": [ "Any damage done to Bidoof by attacks from Lightning Pokémon is reduced by 20 (after applying Weakness and Resistance)." ], "types": [ "Colorless" ], "attacks": [ { "name": "Tackle", "cost": [ "Colorless", "Colorless" ], "convertedEnergyCost": 2, "damage": "30", "text": "" } ], "weaknesses": [ { "type": "Fighting", "value": "+10" } ], "imageUrlHiRes": "https://images.pokemontcg.io/dp2/73_hires.png", "nationalPokedexNumber": 399, "evolvesTo": [ "Bibarel" ] },

Ultra Prism - Update Rarity Field

The rarity field on all Ultra Prism cards needs to get filled out.

Please comment here if you pick this up so multiple people don't start this and waste their time.

Snorlax delta has two "abilities"

API currently doesn't have room for this, which is a bummer.

I think we would have to change the json shape to have a list of ability objects, instead of just one.

https://pokemontcg.io/cards/ex15-10

"ability": [{
  "name": "Bedhead",
  "text": "As long as Snorlax remains Asleep between turns, put 2 damage counters on 1 of the Defending Pokémon.",
  "type": "Poké-Body"
}, {
  "name": "Dozing",
  "text": "Once during your turn (before your attack), if Snorlax is your Active Pokemon, you may remove 2 damage counters from Snorlax and Snorlax is now Asleep. This power can't be used if Snorlax is affected by a Special Condition.",
  "type": "Poké-Power"
}]

SM149 Image showing SM148 card image.

It looks like there's a small error in one of the images for the SM Promos. both SM148 and SM149 have images the SM148 Champion's Festival images, when SM149 is a Suicune!

Missing images

Hi,

I'v noticed that the following images are missing:

https://images.pokemontcg.io/xyp/XY185.png
https://images.pokemontcg.io/xyp/XY186.png
https://images.pokemontcg.io/xyp/XY187.png
https://images.pokemontcg.io/xyp/XY188.png
https://images.pokemontcg.io/xyp/XY189.png
https://images.pokemontcg.io/xyp/XY190.png
https://images.pokemontcg.io/xyp/XY191.png
https://images.pokemontcg.io/xyp/XY192.png
https://images.pokemontcg.io/xyp/XY194.png
https://images.pokemontcg.io/xyp/XY196.png
https://images.pokemontcg.io/xyp/XY198.png
https://images.pokemontcg.io/xyp/XY199.png
https://images.pokemontcg.io/xyp/XY200.png
https://images.pokemontcg.io/xyp/XY201.png
https://images.pokemontcg.io/xyp/XY202.png
https://images.pokemontcg.io/xyp/XY203.png
https://images.pokemontcg.io/xyp/XY204.png
https://images.pokemontcg.io/xyp/XY205.png
https://images.pokemontcg.io/xyp/XY206.png
https://images.pokemontcg.io/xyp/XY207.png
https://images.pokemontcg.io/xyp/XY208.png
https://images.pokemontcg.io/xyp/XY209.png
https://images.pokemontcg.io/xyp/XY210.png
https://images.pokemontcg.io/xyp/XY211.png
https://images.pokemontcg.io/xyp/XY193.png
https://images.pokemontcg.io/xyp/XY195.png
https://images.pokemontcg.io/xyp/XY197.png
https://images.pokemontcg.io/hsp/HGSS21.png
https://images.pokemontcg.io/smp/SM144.png
https://images.pokemontcg.io/hsp/HGSS17.png
https://images.pokemontcg.io/hsp/HGSS19.png
https://images.pokemontcg.io/smp/SM125.png
https://images.pokemontcg.io/smp/SM136.png
https://images.pokemontcg.io/ex5/102.png
https://images.pokemontcg.io/hsp/HGSS20.png
https://images.pokemontcg.io/hsp/HGSS22.png
https://images.pokemontcg.io/hsp/HGSS24.png
https://images.pokemontcg.io/smp/SM156.png
https://images.pokemontcg.io/hsp/HGSS23.png
https://images.pokemontcg.io/hsp/HGSS25.png
https://images.pokemontcg.io/smp/SM146.png
https://images.pokemontcg.io/smp/SM155.png
https://images.pokemontcg.io/smp/SM147.png
https://images.pokemontcg.io/smp/SM93.png
https://images.pokemontcg.io/ecard2/67.png
https://images.pokemontcg.io/smp/SM135.png

Pokemon SP updates

I am going to fix all of the pokemon SP names (e.g. "Dialga G", "Lucario GL", "Gallade 4", etc.), but while I'm at it, I'd like to add a "Pokemon SP" tag to the cards, but I'm not sure where it should go.

I was thinking about putting it in the "text" field, but perhaps a new field called "tags", which contains an array of these values?

This field could also be used for "Team Plasma", "Ultra Beast", and any other special tags which are referenced in other card's text but aren't part of the pokemon's name.

It could also be used for "Pokemon EX" and "Pokemon GX" so that we can get that data out of the "subtype" field, and use the subtype field for the pokemon's stage (since we can't currently search for stage-2 GX Pokemon)

Some vales are the wrong type for HP and evolvesTo

Some HP values were recently made ints when they should be strings. evolvesTo should be an array of strings but for some cards they are just strings (I did not try and verify if any cards actually had multiple evolvesTo but the vast majority of cards had it as an array).

Both of these things break the go sdk from unmarshalling the json (if it's modified to have read evolvesTo from the json).

Wrong images for SMP

I've found some of the images are not correct on SMP cards.
Open the imageUrl or imageUrlHiRes and you will see Articuno instead of Zapdos.

"id": "smp-SM145",
      "name": "Zapdos",
      "nationalPokedexNumber": 145,
      "imageUrl": "https://images.pokemontcg.io/smp/SM145.png",
      "imageUrlHiRes": "https://images.pokemontcg.io/smp/SM145_hires.png",
...

Standard Legal Outdated

The standard legal format is currently outdated since it should only be from Sun & Moon onwards.
Is there any way I can update it or it must be you? (Haven't found a way in the JSONs in this repo)

Aquapolis and Skyridge IDs on cards numbered H1–H32

The cards numbered H1–H32 in both Aquapolis and Skyridge have their ids weirdly appended to the end of the set. For example, ecard2-H1 is ecard2-151 (the set has 150 "regular" cards). Could this be changed to the actual number? Of course, the scan URLs contain the "appended" ID.

Dataset for theme decks

I'm using this API for a project I'm working on and was looking for a way to also track the theme decks. I've started building the dataset myself, figured I'd post here and see if there's any interest in it being PR'd when I'm done. No idea when that will be though.

The data model I'm using looks roughly like this - open to feedback and any information others might also want to see. The id naming convention is also open to change, I just picked something unique.

[
    {
        "id": "d-base1-1",
        "name": "Overgrowth",
        "cards": [
            { "id": "base1-44", "count": 4 },
            { "id": "base1-30", "count": 2 },
            { "id": "base1-69", "count": 4 },
            { "id": "base1-33", "count": 2 },
            { "id": "base1-17", "count": 1 },
            { "id": "base1-65", "count": 4 },
            { "id": "base1-64", "count": 3 },
            { "id": "base1-35", "count": 2 },
            { "id": "base1-6", "count": 1 },
            { "id": "base1-91", "count": 2 },
            { "id": "base1-93", "count": 2 },
            { "id": "base1-94", "count": 1 },
            { "id": "base1-90", "count": 2 },
            { "id": "base1-95", "count": 2 },
            { "id": "base1-99", "count": 16 },
            { "id": "base1-102", "count": 12 }
        ]
    }
]

Aquapolis Holo Numbering

RE: PokemonTCG/pokemon-tcg-api#74

I'd be happy to push an update for this issue, but I wanted to make sure that changing them to non numeric values won't break anything in the API.

@adback03: Is there any problem with either the card ID or card Number being changed to non-numeric values (e.g. "number": "182" becomes "number": "H32", and "id": "ecard2-182" becomes "id": "ecard2-H2")?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.