Handle LocalStorage unavailability properly

[policystat]

Handle LocalStorage unavailability properly

[caffodian]

We currently use store.js. so one initial take on this would be to determine if the store wrapper is present, if so, use that. else use the localstorage API directly, and try to handle errors properly.

[caffodian]

This will be quite difficult to test.

I'm not convinced that disabling DOM Storage is actually the same as disallowing it. Disabling DOM Storage makes localStorage null. But the production stacktrace has something like Access is denied

[caffodian]

By spec,

it actually throws an exception:

https://mathiasbynens.be/notes/localstorage-pattern#comment-9

[caffodian]

So one thing to verify is whether or not store.js uses this pattern.

If so, great, let's just swap.

If not, this plugin needs to keep a state of whether or not localStorage is available, based on the results of that ugly try/catch idea.

[caffodian]

Not currently a huge fan of the existing "roll your own suggestions by just putting everything into a string, separated by nbsps" implementation...

[caffodian]

Possible way to manually test it: go into private browsing mode in Chrome?

[caffodian]

Found #23 while testing this, which makes manual testing quite annoying, since you can't consistently typo a word without the wrapped nbsps.

[caffodian]

Next problem: how to properly mock the different localstorage states. sinon doesn't seem very happy with me attempting to mock localStorage.getItem, but I may be doing something wrong. error message very cryptic.

[caffodian]

Possible way to test this: customers reported it when we were not a trusted site in IE.

[caffodian]

fixed in #24