Giter Site home page Giter Site logo

Comments (5)

caffodian avatar caffodian commented on June 30, 2024

Articulating some points better:

Doing one bookmark per batch is nice. However, restoring bookmarks is expensive regardless of whether it actually does something visible to the user (because span removal is required, or checks are required.)

Also, by creating the bookmark only once per batch, we create problems when you have multiple excessively large blocks. Because things are now more responsive, it's possible to do more things and get the selection restored to the wrong place.

from ckeditor-spell-check-plugin-js-dev-edge.

caffodian avatar caffodian commented on June 30, 2024

We need to:

  • not create bookmarks unless needed
  • also shorten the lifetime of any other bookmark, as much as possible. Ideally it only gets created when we actually are working on a range that crosses it.

from ckeditor-spell-check-plugin-js-dev-edge.

caffodian avatar caffodian commented on June 30, 2024

I might be going insane but it's possible that with all the various changes we made along the way, that bookmarking is no longer needed (except for span removal)

from ckeditor-spell-check-plugin-js-dev-edge.

caffodian avatar caffodian commented on June 30, 2024

One ugly case we don't handle properly (which makes figuring out bookmarks difficult) - if a word is actually multiple text nodes and you type into the middle of it

from ckeditor-spell-check-plugin-js-dev-edge.

caffodian avatar caffodian commented on June 30, 2024

The render event already takes a rootElement. Is it sufficient to determine if the selection falls inside?

from ckeditor-spell-check-plugin-js-dev-edge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.