polygenelubricants/planning-poker

Just Planning Poker is a simple lightweight planning poker web application written in .Net Core 8 with Blazor WebAssembly.

planning-poker's Issues

Reconnect attempts to join non-existing server

PR #16 fixes joining non-existing servers, but the reconnect feature was overlooked, and will still attempt to join a server if the user has previously been in this session. This needs to be addressed on the linked line, by checking for _serverExists.

https://github.com/PolygeneLubricants/planning-poker/blob/c8a44f38bcdb81eb48798a50e3fac804842df034/src/PlanningPoker.Client/Pages/Session/Session.razor#L161C16-L161C37

Make the "Pick a username" form submittable by Enter

We have the "Pick a username" form that asks to enter your name. Please make it easily submittable by the Enter (or Ctrl+Enter, at least), to make it quicker to fill.

Allow non-number values in Mode calculation

Sessions who use non-number cards, like 👍 and ?, will not be included in the mode calculation, as this only filters for cards parsable as decimal.

Steps to reproduce:

1. Create session with non-number card, 👍.
2. Pick this card and Show result
3. Mode is empty

Resolution
Expand Mode calculation to allow non-number cards to be a valid mode result.

Replace Moq with NSubstitute

As raised in moq/moq#1372, Moq now contains closed source, SponsorLink, that creates network traffic on build. This is a security vulnerability, that will leak into this project if not fixed.

Proposed resolution is to replace Moq with NSubstitute.

Visiting unknown sessions gives an error and not a 404

Visiting an unknown session will give an error in the UI, due to the Hub returning an exception, instead of redirecting to a 404 page, telling the user that the session does not exist.

Steps to recreate:

1. Access https://justplanningpoker.com/server/this-session-probably-does-not-exist
2. Observe.
   

Resolution:
Either A or B
A:
Implement proper on failure handling in the Join Hub method, and handle this state in the UI when attempting to join a server, by redirecting to a 404.

B:
Implement an Exists endpoint in the Hub, which the UI will call prior to attempting to join the server. If the server does not exist, redirect to a 404.

Improve UX when specifying card set on session creation

The current UI is not very elegant when creating a new session, and specifying cards.
I propose the following changes:

• Add cards in a multi-select input field, so space creates an option, instead of a raw comma separated list. Example:
  
• Add presets with common alternatives to the default planning poker card set, like Fibonacci, T-shirts.
• Save the last chosen card set in local storage, for the given user.