polymerelements/contributionguide

Canonical repo for the Polymer Elements contribution guide.

contributionguide's Issues

Jsbin example import misses quote

The default jsbin linked in CONTRIBUTING.md https://jsbin.com/cagaye/edit?html,output misses a quote in the paper-button href import.

If you then edit this import, the jsbin syntax highlighting will crash and editing the jsbin becomes a lot harder.

Expected outcome

<link rel="import" href="paper-button/paper-button.html">

Actual outcome

<link rel="import" href="paper-button/paper-button.html>

GitHub multiple issue reference is incorrect

To close multiple issues in 1 Pullrequest, Fixes #32, #40 does not work. It will close issue 32 and only reference issue 40.

To correctly close all issues, the correct notation is Fixes #32, fixes #40.

Some more explanation: http://stackoverflow.com/a/3551299/2761676

P.S. if the issues are referenced in a commit and a branch is rebased, it will regenerate a "this issue is referenced in..." message. Therefore it is better to only include references to issues in the PR description.