eth-contracts's People
Forkers
skyinglyh1 prodog cayden jasonzhoupw renlulu cleancoindev dmitriigerasimov codeislaw0108 spintrade smartspintrade symcryptosis liyue201 vanruch briliantcoin 0xa8c81519 dendisuhubdy tinyhill666 rsc-dev christianxiao jeiwan hsouf markemcintosh eodgooch blockhubcodes wuzhanfly sunnysingh97g nipz kslashh serial-coder buzizima1985 sharonduu devfans mindcarver bradleecoder bsurtokens amarachukwu1 zzxap aurumlabs noneshen freeelancer brvx rabbithophop grace-wong-1998 cybertrait sallywang147 peacebeuponu94 robbiewilliam filipaze log4leo levenston lance-web3 yanchain hoangcongphuc97 al1tr kalbroni7 prazolbista zeynepkavak27 palettechain oblzh zerppen andreaugusto11eth-contracts's Issues
Possible security issue with unlimited epoch length
Here https://github.com/polynetwork/eth-contracts/blob/2.0/contracts/core/cross_chain_manager/logic/EthCrossChainManagerImplementation.sol#L127, we only ensure proof header is after the epoch change, but we didn't specify the epoch end here, this would lead to a possible vulnerability open to stale expired validators.
Add app to Damn Vulnerable Defi
please fix your bug on class EthCrossChainManager#91
bug: merkleProve
uint size = (_auditPath.length - off) / 33;
for example: _auditPath.length - off = 65.
before 33 is ok. after 32 data (65-33) is is arbitrary.
Suggestion: Create a folder with all contracts
Create a folder with all contracts instead contract per repository
poly-contracts/
- neo-contracts/
- ont-contracts/
- eth-contracts/
2.0 CallerFactory public methods should be guarded by onlyAdmin
Looks missing onlyAdmin guard for setAdmin and setChildren method of CallFactory contract in 2.0.
Compromised / hacked
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.