Table of Contents
- Overview
- Quickstart
- Example
- Supported rubies
- Fixing Smell Warnings
- Sources
- Code smells
- Configuration
- Usage
- Developing Reek / Contributing
- Output formats
- Working with Rails
- Integrations
- Brothers and sisters
- Contributors
- Additional resources
Reek is a tool that examines Ruby classes, modules and methods and reports any Code Smells it finds.
For an excellent introduction to Code Smells and Reek check out this blog post or that one. There is also this talk from the RubyConf Portugal.
Install it via rubygems:
gem install reek
and run it like this:
reek [options] [dir_or_source_file]*
Imagine a source file demo.rb
containing:
class Dirty
# This method smells of :reek:NestedIterators but ignores them
def awful(x, y, offset = 0, log = false)
puts @screen.title
@screen = widgets.map { |w| w.each { |key| key += 3 * x } }
puts @screen.contents
end
end
Reek will report the following code smells in this file:
$ reek demo.rb
demo.rb -- 8 warnings:
[1]:Dirty has no descriptive comment (IrresponsibleModule)
[3]:Dirty#awful has 4 parameters (LongParameterList)
[3]:Dirty#awful has boolean parameter 'log' (BooleanParameter)
[3]:Dirty#awful has the parameter name 'x' (UncommunicativeParameterName)
[5]:Dirty#awful has the variable name 'w' (UncommunicativeVariableName)
[3]:Dirty#awful has unused parameter 'log' (UnusedParameters)
[3]:Dirty#awful has unused parameter 'offset' (UnusedParameters)
[3]:Dirty#awful has unused parameter 'y' (UnusedParameters)
Reek is officially running on the following MRI rubies:
- 2.1
- 2.2
- 2.3
Other rubies like Rubinius or JRuby are not officially supported but should work as well.
Reek focuses on high-level code smells, so we can't tell you how to fix warnings in a generic fashion; this is and will always be completely dependent on your domain language and business logic.
That said, an example might help you get going. Have a look at this sample of a Ruby on Rails model (be aware that this is truncated, not working code):
class ShoppingCart < ActiveRecord::Base
has_many :items
def gross_price
items.sum { |item| item.net + item.tax }
end
end
class Item < ActiveRecord::Base
belongs_to :shopping_cart
end
Running Reek on this file like this:
reek app/models/shopping_cart.rb
would report:
[5, 5]:ShoppingCart#gross_price refers to item more than self (FeatureEnvy)
Fixing this is pretty straightforward. Put the gross price calculation for a single item
where it belongs, which would be the Item
class:
class ShoppingCart < ActiveRecord::Base
has_many :items
def gross_price
items.sum { |item| item.gross_price }
end
end
class Item < ActiveRecord::Base
belongs_to :shopping_cart
def gross_price
net + tax
end
end
The Code Smells docs may give you further hints - be sure to check out those first when you have a warning that you don't know how to deal with.
There are multiple ways you can have Reek work on sources, the most common one just being
reek lib/
If you don't pass any source arguments to Reek it just takes the current working directory as source.
So
reek
is the exact same thing as being explicit:
reek .
Additionally you can pipe code to Reek like this:
echo "class C; def m; end; end" | reek
This would print out:
$stdin -- 3 warnings:
[1]:C has no descriptive comment (IrresponsibleModule)
[1]:C has the name 'C' (UncommunicativeModuleName)
[1]:C#m has the name 'm' (UncommunicativeMethodName)
Reek currently includes checks for some aspects of Control Couple, Data Clump, Feature Envy, Large Class, Long Parameter List, Simulated Polymorphism, Too Many Statements, Uncommunicative Name, Unused Parameters and more. See the Code Smells for up to date details of exactly what Reek will check in your code.
Note that Unused Private Method is disabled by default because it is kind of controversial which means you have to explicitly activate in your configuration via
UnusedPrivateMethod:
enabled: true
For a basic overview, run
reek --help
For a summary of those CLI options see Command-Line Options.
Configuring Reek via a configuration file is by far the most powerful way.
There are three ways of passing Reek a configuration file:
- Using the CLI
-c
switch (see Command-line interface above) - Having a file ending with
.reek
either in your current working directory or in a parent directory (more on that later) - Having a file ending with
.reek
in your home directory
The order in which Reek tries to find such a configuration file is exactly the above: first it checks if we have given it a configuration file explicitly via CLI; then it checks the current working directory for a file and if it can't find one, it traverses up the directories until it hits the root directory; lastly, it checks your home directory.
As soon as Reek detects a configuration file it stops searching
immediately, meaning that from Reek's point of view there exists
exactly one configuration file and one configuration, regardless
of how many *.reek
files you might have on your filesystem.
We put a lot of effort into making Reek's configuration as self explanatory as possible so the
best way to understand it is by looking at a simple
example (e.g. config.reek
in your project directory):
---
### Generic smell configuration
# You can disable smells completely
IrresponsibleModule:
enabled: false
# You can use filters to silence Reek warnings.
# Either because you simply disagree with Reek (we are not the police) or
# because you want to fix this at a later point in time.
NestedIterators:
exclude:
- "MyWorker#self.class_method" # should be refactored
- "AnotherWorker#instance_method" # should be refactored as well
# A lot of smells allow fine tuning their configuration. You can look up all available options
# in the corresponding smell documentation in /docs. In most cases you probably can just go
# with the defaults as documented in defaults.reek.
DataClump:
max_copies: 3
min_clump_size: 3
### Directory specific configuration
# You can configure smells on a per-directory base.
# E.g. the classic Rails case: controllers smell of NestedIterators (see /docs/Nested-Iterators.md) and
# helpers smell of UtilityFunction (see docs/Utility-Function.md)
"web_app/app/controllers":
NestedIterators:
enabled: false
"web_app/app/helpers":
UtilityFunction:
enabled: false
### Excluding directories
# Directories below will not be scanned at all
exclude_paths:
- lib/legacy
- lib/rake/legacy_tasks
If you have a directory directive for which a default directive exists, the more specific one (which is the directory directive) will take precedence.
This configuration for instance:
---
IrresponsibleModule:
enabled: false
TooManyStatements:
max_statements: 5
"app/controllers":
TooManyStatements:
max_statements: 10
translates to:
- IrresponsibleModule is disabled everywhere
- TooManyStatements#max_statements is 10 in "app/controllers"
- TooManyStatements#max_statements is 5 everywhere else
For more details please check out the Basic Smell Options
which are supported by every smell type. As you can see above, certain smell
types offer a configuration that goes beyond that of the basic smell options, for instance
Data Clump.
All options that go beyond the Basic Smell Options
are documented in the corresponding smell type /docs page (if you want to get a quick overview over all possible
configurations you can also check out the default.reek
file in this repository.
Note that you do not need a configuration file at all. If you're fine with all the defaults we set you can skip this completely.
In case you need to suppress a smell warning and you can't or don't want to use configuration files for whatever reasons you can also use special source code comments like this:
# This method smells of :reek:NestedIterators
def smelly_method foo
foo.each {|bar| bar.each {|baz| baz.qux}}
end
You can even pass in smell specific configuration settings:
# :reek:NestedIterators: { max_allowed_nesting: 2 }
def smelly_method foo
foo.each {|bar| bar.each {|baz| baz.qux}}
end
This is an incredible powerful feature and further explained under Smell Suppresion.
Integrating tools like Reek into an existing larger codebase can be daunting when you have to fix possibly hundreds or thousands of smell warnings first. Sure you could manually disable smell warnings like shown above but depending on the size of your codebase this might not be an option. Fortunately Reek provides a 'todo' flag which you can use to generate a configuration that will suppress all smell warnings for the current codebase:
reek --todo lib/
This will create the file '.todo.reek' in your current working directory.
You can then use this as your configuration - since your working directory probably is your project root in most cases you don't have to tell Reek explicitly to use '.todo.reek' because Reek will automatically pick it up and use it as configuration file. See Configuration Loading above.
If for whatever reasons you decide to put '.todo.reek' somewhere else where Reek won't pick it up automatically you need to tell Reek explicitly to do so via:
reek -c whatever/.todo.reek lib/
Note that if you re-run
reek --todo lib/
'.todo.reek' will get overwritten with a possibly updated configuration.
Besides the obvious
reek [options] [dir_or_source_file]*
there are quite a few other ways how to use Reek in your projects:
- Use Reek's Rake task to automate detecting code smells
- Add Reek's custom matcher to your RSpec examples
- Include Reek using the Developer API
The first thing you want to do after checking out the source code is to run Bundler:
bundle install
and then run the tests:
bundle exec rspec spec/your/file_spec.rb # Runs all tests in spec/your/file_spec.rb
bundle exec rspec spec/your/file_spec.rb:23 # Runs test in line 23
bundle exec cucumber features/your_file.feature # Runs all scenarios in your_file.feature
bundle exec cucumber features/your_file.feature:23 # Runs scenario at line 23
Or just run the whole test suite:
bundle exec rake
This will run the tests (RSpec and Cucumber), RuboCop and Reek itself.
You can also run:
bundle exec rake ci
This will run everything the default task runs and also Ataru and Mutant. This is the task that we run on Travis as well and that determines if your pull request is green or red.
Another useful Rake task is the console
task. This will throw you right into an environment where you can play around with Reeks modules and classes:
bundle exec rake console
[3] pry(main)> require_relative 'lib/reek/examiner'
=> true
[4] pry(main)> Reek::Examiner
=> Reek::Examiner
Have a look at our Developer API for more inspiration.
From then on you should check out:
If you don't feel like getting your hands dirty with code there are still other ways you can help us:
- Open up an issue and report bugs
- Suggest other improvements like additional smells for instance
Reek supports 5 output formats:
- plain text (default)
- HTML (
--format html
) - YAML (
--format yaml
, see also YAML Reports) - JSON (
--format json
) - XML (
--format xml
)
Making Reek "Rails"-friendly is fairly simple since we support directory specific configurations (directory directives
in Reek talk).
Just add this to your configuration file:
"app/controllers":
IrresponsibleModule:
enabled: false
NestedIterators:
max_allowed_nesting: 2
UnusedPrivateMethod:
enabled: false
"app/helpers":
IrresponsibleModule:
enabled: false
UtilityFunction:
enabled: false
Be careful though, Reek does not merge your configuration entries, so if you already have a directory directive for "app/controllers" or "app/helpers" you need to update those directives instead of copying the above YAML sample into your configuration file.
- overcommit - a Git commit hook manager with support for Reek
- ruby-critic - gem that wraps around static analysis gems such as Reek, flay and flog
- pronto-reek - Reek integration for pronto
- Colorful output for Reek (also with Guard::Preek)
A non-exhaustive list of other static code analyzers you might want to look into:
- debride - analyze code for potentially uncalled / dead methods
- flay - analyze code for structural similarities
- flog - reports the most tortured code in an easy to read pain report
- SandiMeter - checking your Ruby code for Sandi Metz' four rules
- ruby-lint - static code analysis tool
- Fasterer - Fasterer will suggest some speed improvements based on fast-ruby
The Reek core team consists of:
The original author of Reek is Kevin Rutherford.
The author of Reek’s logo is Sonja Heinen.
Notable contributions came from: